Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gccrs: enum type layout needs to respect the enum repr type #3427

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

philberty
Copy link
Member

Addresses #3352

gcc/rust/ChangeLog:

* backend/rust-compile-type.cc (TyTyResolveCompile::get_implicit_enumeral_node_type): use repr (TyTyResolveCompile::visit): update prototype
* backend/rust-compile-type.h: likewise

Addresses #3352

gcc/rust/ChangeLog:

	* backend/rust-compile-type.cc (TyTyResolveCompile::get_implicit_enumeral_node_type):
	use repr
	(TyTyResolveCompile::visit): update prototype
	* backend/rust-compile-type.h: likewise

Signed-off-by: Philip Herron <[email protected]>
@philberty philberty added this to the Remaining typecheck issues milestone Feb 11, 2025
@philberty philberty added this pull request to the merge queue Feb 11, 2025
Merged via the queue into master with commit dbb51c0 Feb 11, 2025
12 checks passed
@philberty philberty deleted the phil/enum-layout-repr branch February 13, 2025 13:08
@powerboat9
Copy link
Collaborator

Just a heads up, since I noticed it during a rebase -- TypeCheckBase::parse_repr_options always gives a representation type of isize (with accompanying TODO comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants