Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nr2.0: Implement macro_use for modules #3451

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

powerboat9
Copy link
Collaborator

No description provided.

gcc/rust/ChangeLog:

	* resolve/rust-early-name-resolver-2.0.cc:
	Include rust-attribute-values.h.
	(Early::visit): If a module has a macro_use attribute, avoid
	pushing a new textual macro scope.

gcc/testsuite/ChangeLog:

	* rust/compile/nr2/exclude: Remove entries.

Signed-off-by: Owen Avery <[email protected]>
Copy link
Member

@CohenArthur CohenArthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!! much simpler than what we had in nr1.0 lol. if this is enough to pass the nested macro testsuite then I'm really happy, well done!

@CohenArthur CohenArthur added this pull request to the merge queue Feb 25, 2025
Merged via the queue into Rust-GCC:master with commit e4ebd02 Feb 25, 2025
12 checks passed
@powerboat9 powerboat9 deleted the macro-2-use branch February 25, 2025 12:50
Copy link
Member

@P-E-P P-E-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to submit the review :( Github should really leave a message when a review has been started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants