warning: unneeded `return` statement --> src/host/jack/mod.rs:177:13 | 177 | return Err(format!("Failed to open client because of error: {:?}", e)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return help: remove `return` | 177 - return Err(format!("Failed to open client because of error: {:?}", e)); 177 + Err(format!("Failed to open client because of error: {:?}", e)) |

unneeded `return` statement: src/host/jack/mod.rs#L174

warning: unneeded `return` statement --> src/host/jack/mod.rs:174:13 | 174 | return Ok(client); | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default help: remove `return` | 174 - return Ok(client); 174 + Ok(client) |

returning the result of a `let` binding from a block: src/host/jack/stream.rs#L278

warning: returning the result of a `let` binding from a block --> src/host/jack/stream.rs:278:5 | 277 | let data = unsafe { Data::from_parts(data, len, JACK_SAMPLE_FORMAT) }; | ---------------------------------------------------------------------- unnecessary `let` binding 278 | data | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return = note: `#[warn(clippy::let_and_return)]` on by default help: return the expression directly | 277 ~ 278 ~ unsafe { Data::from_parts(data, len, JACK_SAMPLE_FORMAT) } |

writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do: src/host/jack/stream.rs#L273

warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do --> src/host/jack/stream.rs:273:43 | 273 | fn temp_buffer_to_data(temp_input_buffer: &mut Vec<f32>, total_buffer_size: usize) -> Data { | ^^^^^^^^^^^^^ help: change this to: `&mut [f32]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `#[warn(clippy::ptr_arg)]` on by default

this function has too many arguments (8/7): src/host/jack/stream.rs#L241

warning: this function has too many arguments (8/7) --> src/host/jack/stream.rs:241:5 | 241 | / fn new( 242 | | out_ports: Vec<jack::Port<jack::AudioOut>>, 243 | | in_ports: Vec<jack::Port<jack::AudioIn>>, 244 | | sample_rate: SampleRate, ... | 251 | | error_callback_ptr: ErrorCallbackPtr, 252 | | ) -> Self { | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default

very complex type used. Consider factoring parts into `type` definitions: src/host/jack/stream.rs#L247

warning: very complex type used. Consider factoring parts into `type` definitions --> src/host/jack/stream.rs:247:31 | 247 | output_data_callback: Option< | _______________________________^ 248 | | Box<dyn FnMut(&mut Data, &OutputCallbackInfo) + Send + 'static>, 249 | | >, | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity

very complex type used. Consider factoring parts into `type` definitions: src/host/jack/stream.rs#L246

warning: very complex type used. Consider factoring parts into `type` definitions --> src/host/jack/stream.rs:246:30 | 246 | input_data_callback: Option<Box<dyn FnMut(&Data, &InputCallbackInfo) + Send + 'static>>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity

very complex type used. Consider factoring parts into `type` definitions: src/host/jack/stream.rs#L229

warning: very complex type used. Consider factoring parts into `type` definitions --> src/host/jack/stream.rs:229:27 | 229 | output_data_callback: Option<Box<dyn FnMut(&mut Data, &OutputCallbackInfo) + Send + 'static>>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity

very complex type used. Consider factoring parts into `type` definitions: src/host/jack/stream.rs#L228

warning: very complex type used. Consider factoring parts into `type` definitions --> src/host/jack/stream.rs:228:26 | 228 | input_data_callback: Option<Box<dyn FnMut(&Data, &InputCallbackInfo) + Send + 'static>>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default

use of `default` to create a unit struct: src/host/jack/stream.rs#L105

warning: use of `default` to create a unit struct --> src/host/jack/stream.rs:105:86 | 105 | let port_try = client.register_port(&format!("out_{}", i), jack::AudioOut::default()); | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

use of `default` to create a unit struct: src/host/jack/stream.rs#L40

warning: use of `default` to create a unit struct --> src/host/jack/stream.rs:40:84 | 40 | let port_try = client.register_port(&format!("in_{}", i), jack::AudioIn::default()); | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default

casting to the same type is unnecessary (`i64` -> `i64`): src/host/alsa/mod.rs#L899

warning: casting to the same type is unnecessary (`i64` -> `i64`) --> src/host/alsa/mod.rs:899:40 | 899 | ts.tv_sec as i64 * 1_000_000_000 + ts.tv_nsec as i64 | ^^^^^^^^^^^^^^^^^ help: try: `ts.tv_nsec` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

casting to the same type is unnecessary (`i64` -> `i64`): src/host/alsa/mod.rs#L899

warning: casting to the same type is unnecessary (`i64` -> `i64`) --> src/host/alsa/mod.rs:899:5 | 899 | ts.tv_sec as i64 * 1_000_000_000 + ts.tv_nsec as i64 | ^^^^^^^^^^^^^^^^ help: try: `ts.tv_sec` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

casting to the same type is unnecessary (`u32` -> `u32`): src/host/alsa/mod.rs#L437

warning: casting to the same type is unnecessary (`u32` -> `u32`) --> src/host/alsa/mod.rs:437:53 | 437 | max_sample_rate: SampleRate(max_rate as u32), | ^^^^^^^^^^^^^^^ help: try: `max_rate` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

casting to the same type is unnecessary (`u32` -> `u32`): src/host/alsa/mod.rs#L436

warning: casting to the same type is unnecessary (`u32` -> `u32`) --> src/host/alsa/mod.rs:436:53 | 436 | min_sample_rate: SampleRate(min_rate as u32), | ^^^^^^^^^^^^^^^ help: try: `min_rate` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `#[warn(clippy::unnecessary_cast)]` on by default

wasm32-bindgen-test (wasm32-unknown-unknown)

ubuntu-test

very complex type used. Consider factoring parts into `type` definitions: src/host/oboe/output_callback.rs#L10

warning: very complex type used. Consider factoring parts into `type` definitions --> src/host/oboe/output_callback.rs:10:14 | 10 | data_cb: Box<dyn FnMut(&mut Data, &OutputCallbackInfo) + Send + 'static>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity

very complex type used. Consider factoring parts into `type` definitions: src/host/oboe/input_callback.rs#L10

warning: very complex type used. Consider factoring parts into `type` definitions --> src/host/oboe/input_callback.rs:10:14 | 10 | data_cb: Box<dyn FnMut(&Data, &InputCallbackInfo) + Send + 'static>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default

clippy-test

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

clippy-test

android-check

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

android-check

asmjs-wasm32-test (wasm32-unknown-emscripten)

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, mymindstorm/setup-emsdk@v10, actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

asmjs-wasm32-test (wasm32-unknown-emscripten)