Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove once_cell dependency #800

Merged
merged 4 commits into from
Dec 17, 2023

Conversation

james7132
Copy link
Contributor

Removes the once_cell dependency, using std::sync::OnceLock instead.

This bumps the MSRV of the crate from 1.60 to 1.70. Given that #277 is currently unresolved, is this acceptable?

@est31
Copy link
Member

est31 commented Sep 20, 2023

I think this is a little bit too soon. 1.70 was released June 1st, we should wait at least until mid/end of december.

@adsick
Copy link

adsick commented Dec 15, 2023

mid of december has come)

@est31
Copy link
Member

est31 commented Dec 15, 2023

there seems to be CI failure. @james7132 could you have a look?

@james7132
Copy link
Contributor Author

The new CI failures seem to be unrelated.

@est31 est31 merged commit 310160f into RustAudio:master Dec 17, 2023
14 of 16 checks passed
@est31
Copy link
Member

est31 commented Dec 17, 2023

Regarding the CI failures, see #810

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants