Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix runtime errors on Android targets #808

Closed
wants to merge 1 commit into from
Closed

Fix runtime errors on Android targets #808

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 22, 2023

When developing an Android app using cpal for sound effects I had to configure my build.rs to do this to avoid crashes at startup on certain phones. I figured I should help people avoid having to do the same debugging / work (it took many hours to figure this out) by adding the necessary code to cpal's build.rs.

@est31
Copy link
Member

est31 commented Oct 23, 2023

Is there any further reading on these errors? Error messages, stack overflow threads, etc.

@ghost
Copy link
Author

ghost commented Oct 23, 2023

@est31 Yeah, I think it was something about a dynamic library it couldn't find (?). Removing cpal from the dependencies fixed the error, so it was definitely related to this. So I googled a bit and found this fix. To be honest I don't completely remember the details, it's been a while. If necessary I could remove the fix from my project and re-create the error to put it here.

@est31
Copy link
Member

est31 commented Oct 23, 2023

@PhilosophicalProgrammer

If necessary I could remove the fix from my project and re-create the error to put it here.

If possible, that would be very helpful, because then we know why we added this piece of code (and can tell if the code will need it in the future). Also it might be helpful to be more concrete with the phone models. Are they recent? are they older? Is the fix still needed in 5 years?

@ghost ghost closed this Oct 23, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant