-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ActivityDefinition InteractionType #35
base: master
Are you sure you want to change the base?
Conversation
ActivityDefinition has been extended to include: interactionType correctResponsesPattern choices scale target step This as been based on the work carried out by Paul Carpenter and is my first GitHub submission.
I am wondering when this PR will be merged into master? We need this feature to get choices from statement. |
Prioritization of work on the OSS libs is difficult, I hope to have a chance to put time into the open PRs in the next couple of weeks. It will speed up the process of PR review if you rebase the changes to the current |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like @brianjmiller said above and I mentioned over on #34, this commit history is pretty messy and it has a lot of changes that aren't relevant to the core intent of the PR.
A lot of what I requested over on #34 is also applicable here. Since this PR is about extending ActivityDefinition, please take a look at the commit history and take out changes that aren't relevant to that work. My guess is that you only need the changes included in a6d2264 and 603a702.
This PR contains the commented change suggestions from #17