[SKP-127] 카테고리 페이지 마크업 및 조회 API #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yusiny
changed the title
yusiny
approved these changes
Aug 13, 2024
| return res; | ||
| }; | ||
|
|
||
| const onRejected = async (error: AxiosError) => { |
There was a problem hiding this comment.
오옹! 여기서 JWT 이슈 처리하고 재발급 받는 로직 깔끔하네요! status 들만 저희 백에서 실제로 저 상태들로 내려주는지 확인 한번만 해보면 좋을거같아요 짱짱 👍
src/apis/axiosInstance.ts
Outdated
|
|
||
| const statusArray = [4100, 4101, 4102, 4103, 4104]; | ||
|
|
||
| if (originalConfig && includes(statusArray, error.response?.status)) { |
There was a problem hiding this comment.
loadash 라이브러리는 이 비교 때문에 설치하신 건가요?
저는 보통 이런 간단한 배열 비교는 js 배열 내장 includes 함수로 처리했어서! 해당 라이브러리를 꼭 사용해야 하는 이유가 궁금해요 👀
const statusArray = [4100, 4101, 4102, 4103, 4104];
statusArray.includes(error.response?.status);There was a problem hiding this comment.
오 너무 좋아요! 무분별한 라이브러리 사용을 지양해야겠어요 ㅎㅎ! 수정 반영했습니다
|
그리고 저도 axios instance 때문에 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🪄 Issue Number
🏆 Details
✅ Need Review
📸 Screenshot
RPReplay_Final1723529039.MP4