-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add blackduck scans to our pipeline #2081
Conversation
The refs seem to be |
I guess the PR number is just as sufficient, so no problem imo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you created some negative tests so we know the PRs can be blocked when positive findings are detected?
Before I excluded the dev dependencies the pipeline on my fork was failing, I guess I could try out another productive dependency to make sure it also fails on regular dependencies. |
While testing blackduck on my fork, I've had 3 findings:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
on: | ||
pull_request: ~ | ||
push: | ||
branches: [2.0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a comment or follow up ticket to change this to main
once we merge 2.0 into it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah good point, perhaps we should add it to whatever ticket we have to switch the default branch back to main.
This PR adds blackduck to our pipeline, check out my fork to see how it works.
In Blackduck, each version is determined by the module version in Lerna and the github_ref_name, aka. the branch name.
So the main branch will look like
1.57.2-main
while branches may look like1.57.2-my-branch
.Additionally, it doesn't scan devDependencies.
Closes SAP/cloud-sdk-backlog#549.