Run helm dependency before helm lint (#4777)

* Update helmExecute.go

* Update helmExecute_test.go

* Try fix format issue

cmd/helmExecute.go

@@ -127,16 +127,16 @@ func runHelmExecute(config helmExecuteOptions, helmExecutor kubernetes.HelmExecu
 }
 
 func runHelmExecuteDefault(config helmExecuteOptions, helmExecutor kubernetes.HelmExecutor, commonPipelineEnvironment *helmExecuteCommonPipelineEnvironment) error {
-	if err := helmExecutor.RunHelmLint(); err != nil {
-		return fmt.Errorf("failed to execute helm lint: %v", err)
-	}
-
 	if len(config.Dependency) > 0 {
 		if err := helmExecutor.RunHelmDependency(); err != nil {
 			return fmt.Errorf("failed to execute helm dependency: %v", err)
 		}
 	}
 
+	if err := helmExecutor.RunHelmLint(); err != nil {
+		return fmt.Errorf("failed to execute helm lint: %v", err)
+	}
+
 	if config.Publish {
 		targetURL, err := helmExecutor.RunHelmPublish()
 		if err != nil {

cmd/helmExecute_test.go

@@ -393,8 +393,8 @@ func TestRunHelmDefaultCommand(t *testing.T) {
 	for i, testCase := range testTable {
 		t.Run(fmt.Sprint("case ", i), func(t *testing.T) {
 			helmExecute := &mocks.HelmExecutor{}
-			helmExecute.On("RunHelmLint").Return(testCase.methodLintError)
 			helmExecute.On("RunHelmDependency").Return(testCase.methodPackageError)
+			helmExecute.On("RunHelmLint").Return(testCase.methodLintError)
 			helmExecute.On("RunHelmPublish").Return(testCase.methodPublishError)
 
 			err := runHelmExecute(testCase.config, helmExecute, &testCase.fileUtils, &cpe)