feat(kubernetesDeploy): Better support for sub-charts #4676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/it-go |
modulo11
force-pushed
the
remove-values-mapping
branch
from
dad0caf to
be85965
Compare
|
/it-go |
modulo11
force-pushed
the
remove-values-mapping
branch
from
be85965 to
a8547dd
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Co-authored-by: Johannes Dillmann <[email protected]>
pbusko
force-pushed
the
remove-values-mapping
branch
from
e3328fa to
68e5342
Compare
|
|
/it-go |
|
@anilkeshav27 Could you have a quick look? Since we only added some Update: I have created an alternative pull request #4829 with minimal diff only containing the necessary changes. So the review is much simpler. |
modulo11
requested review from
loewenstein,
c0d1ngm0nk3y,
pbusko and
anilkeshav27
c0d1ngm0nk3y
approved these changes
Feb 14, 2024
2 tasks
|
Replaced by #4829. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
$key.image.repository/$key.image.tag(before there was onlyimage.$key.repository/image.$key.tagThis supports sub-charts better and reduces drastically the necessity to provide
valuesMappingin such scenarios.