including conditions when starting side cars docker containers #4815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anilkeshav27
changed the title
CCFenner
approved these changes
Feb 5, 2024
| putStringIfNotEmpty(root, "sidecarReadyCommand", m.Spec.Sidecars[0].ReadyCommand) | ||
| // if there one side car do not check conditions and consider the only side care as default . this is default behaviour | ||
| // if there are more than one side car then check conditions, | ||
| if len(m.Spec.Sidecars) == 1 { |
There was a problem hiding this comment.
That would slightly change the meaning, but looping over empty sidecars should be fine. But why do we need those ifs at all? Why shouldn't one sidecar have a condition? Taking always the else case (i.e. looping over all sidecars) should always working, for 0,1 and many.
c0d1ngm0nk3y
approved these changes
Feb 6, 2024
| putStringIfNotEmpty(root, "sidecarReadyCommand", m.Spec.Sidecars[0].ReadyCommand) | ||
| // if there one side car do not check conditions and consider the only side care as default . this is default behaviour | ||
| // if there are more than one side car then check conditions, | ||
| if len(m.Spec.Sidecars) == 1 { |
There was a problem hiding this comment.
That would slightly change the meaning, but looping over empty sidecars should be fine. But why do we need those ifs at all? Why shouldn't one sidecar have a condition? Taking always the else case (i.e. looping over all sidecars) should always working, for 0,1 and many.
|
|
/it-go |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
when adding side cars for a piper step, this PR allows to bring in conditions when selecting a side care from conditions