Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usage of BASH from PATH #5282

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

usage of BASH from PATH #5282

wants to merge 2 commits into from

Conversation

h0nIg
Copy link

@h0nIg h0nIg commented Feb 24, 2025

Description

Sometimes bash is not hardcoded into /bin/bash and bash from PATH needs to get used. We need this to run the piper action in our SAP NixOS docker image.

side remark: we have a /bin/sh but we are unsure if the detect script required bash or standard sh

Checklist

  • Tests
  • Documentation
  • Inner source library needs updating

@h0nIg h0nIg requested a review from a team as a code owner February 24, 2025 16:04
Copy link

cla-assistant bot commented Feb 24, 2025

CLA assistant check
All committers have signed the CLA.

@h0nIg h0nIg changed the title use of BASH within PATH use of BASH from PATH Feb 24, 2025
@h0nIg h0nIg changed the title use of BASH from PATH usage of BASH from PATH Feb 24, 2025
@jitendk
Copy link
Contributor

jitendk commented Feb 28, 2025

What about the scans which are running on /bin/bash, will this change not break all such scans which aer dependent on /bin/bash ?

@h0nIg
Copy link
Author

h0nIg commented Mar 2, 2025

What about the scans which are running on /bin/bash, will this change not break all such scans which aer dependent on /bin/bash ?

@jitendk I dont fully understand your question, maybe you can reach out to me via teams.

In general the command will get executed as of today: /bin/bash detect.sh, therefore it ignores the shebang inside detect.sh anyhow. I would like to have it bash detect.sh, which still executes it with bash. It just takes the bash from the PATH variable instead of relying on hardcoded assumptions where bash binary is located

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants