fix(vaultRotateSecretId): AllowOverride for writeVaultSecretIDToStore #5288
+13
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@niki4 wondering if this is the actual root cause as if this was the case this step shouldn't have worked for any Azure user? |
@ashlymat - I also wondered, but I don't understand enough about how this Piper library works. Let me know if there's any other details I can provide about our custom pipeline to help narrow down why it isn't working for us, but it is for other Azure users. |
Googlom
approved these changes
Feb 28, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One of the users reported that vaultRotateSecretId doesn't update secret despite the initiated secret rotation. This may due to the existing secret not being overriden.
Checklist