Playwright 1.48 #262
Draft
Playwright 1.48 #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/RGBA formats r=pehrsons,webrtc-reviewers a=RyanVM This is a simple backport of an WebRTC upstream change. Upstream commit: c3aeffd776a22050aff43c81e4a61da3492fa821. Differential Revision: https://phabricator.services.mozilla.com/D213750
…=pehrsons,webrtc-reviewers a=RyanVM This is a simple backport of an WebRTC upstream change. Upstream commit: 3252f5d8e481b65571ebb95801754a10dc910632 Differential Revision: https://phabricator.services.mozilla.com/D213751
…e buffers with MAP_SHARED r=pehrsons,webrtc-reviewers a=RyanVM This is a simple backport of an WebRTC upstream change. Upstream commit: 025d69b4d0df05f54d7bfcb3a4a2b35b48b83d82 Differential Revision: https://phabricator.services.mozilla.com/D213752
…sed. r=sfoster a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D213811
…was accidentally moved to #PlacesToolbarDropIndicator. r=emilio,desktop-theme-reviewers a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D213955
… an esr repository. r=releng-reviewers,jcristau a=RyanVM As of Thunderbird 128.0esr, Thunderbird VersionTypes will be ESR (the esr suffix will be added). Monthly releases will be using comm-release with RELEASE VersionType. This special case code needs to be removed so UVC will work. Differential Revision: https://phabricator.services.mozilla.com/D213688
… version a=pascalc This was built in a shippable win32 build on Try in https://treeherder.mozilla.org/jobs?repo=try&revision=0d8c6bee15ce9bc54a7749717033fa24e15ca0bf, which was based on 730319d762dc822e7319087f50a31ee268d4fb00, with updated versions of the patches from https://bugzilla.mozilla.org/show_bug.cgi?id=1771192 applied to it that statically link InetBgDL.dll. From there, I sent it through adhoc-signing in mozilla-releng/adhoc-signing#208. The output from that (https://firefox-ci-tc.services.mozilla.com/tasks/EHnFhv77SO6K8D_ZS32fGQ) is what is included in this revision. Original Revision: https://phabricator.services.mozilla.com/D210581 Differential Revision: https://phabricator.services.mozilla.com/D213936
… format. a=pascalc This switches us away from the code signing certificate expiring in June, to a new one valid until 2027. Update subject pin in msix repackaging and issuer pin in the stub installer. Original Revision: https://phabricator.services.mozilla.com/D208633 Differential Revision: https://phabricator.services.mozilla.com/D213937
…t a=pascalc This patch addresses the problem that we currently collect HTTPS-First telemetry for sites that are not reachable at all, be it through always causing a error or through always timing out. - On a downgrade, do not collect telemetry instantly, but instead save the telemetry data in the load state for the downgraded request - That telemetry data will then be copied over into the document load listener of the new request - On a successful request, if we have downgrade data in the load listener, we collect the downgrade telemetry, as the downgrade seems to have been successful - Similar to the downgrade case, we only count the upgrade metric once we encounter a successful request annotated with the information that it was upgraded by HTTPS-First, instead of counting it instantly on the decision to upgrade. This also means the upgrade metric will not include loads that are downgraded again anymore - Add a testcase for a site which is neither reachable via HTTP nor HTTPS, and ensure no telemetry is collected Original Revision: https://phabricator.services.mozilla.com/D210792 Differential Revision: https://phabricator.services.mozilla.com/D211999
…X-ANDROID_127_0_1_BUILD1 a=release CLOSED TREE DONTBUILD
…X_127_0_1_BUILD1 a=release CLOSED TREE DONTBUILD
Ensures that the SelectTranslationsPanel languageInfo cache is refreshed every time the panel would be opened. This prevents a case where the incorrect (previous) document language tag is reported to telemetry in some cases. Original Revision: https://phabricator.services.mozilla.com/D214011 Differential Revision: https://phabricator.services.mozilla.com/D214139
…ence before adding it to the list r=pehrsons,webrtc-reviewers a=RyanVM This is a simple backport of an WebRTC upstream change. Upstream commit: 633a41ff8edec405cefa109ac3c8f9662a020cc1 Differential Revision: https://phabricator.services.mozilla.com/D213749
…out:blank of top-level opaque origins a=RyanVM The primary change of this patch is to add IsInitialDocument() to the "is this an about blank document where I should be able to run scripts despite it not having a matching origin" logic. This is to avoid scheduling content scripts in top-level about:blank in the parent process as mentioned in the bug report. The original use case (supporting execution in top-level about:blank) continues to be supported, which is demonstrated by the still passing tests in test_ext_contentscript_about_blank.html. A new regression test was added (test_toplevel_aboutblank_at_document_start) in the same file, which fails before the fix when run with --tag=in-process-webextensions due to unexpected extra messages like the bug, and passes with the fix. Original Revision: https://phabricator.services.mozilla.com/D213439 Differential Revision: https://phabricator.services.mozilla.com/D214003
…rames a=RyanVM The reported bug is caused by an attempt to schedule a content script in an initial about:blank document/frame for which document_end and document_idle never resolve. Although the bug is about dynamic execution (insertCSS/executeScript/etc), the underlying injection logic is also shared by declarative content scripts. This test adds test coverage for two relevant scenarios: - Content scripts declared via content_scripts in manifest.json (this is also the underlying implementation of contentScripts.register, userScripts.register and scripting.registerContentScripts). This WORKS AS EXPECTED, because scripts never run in initial about:blank ( which is reported at bug 1415539 + bug 1486036 ). - Content scripts executed in existing content as part of extension install via ExtensionPolicyService::InjectContentScripts. This UNEXPECTEDLY results in executions that are stuck and never-settling. The same issue is also relevant to the handleActivateScripts logic, which did not and still does not have explicit coverage for this scenario. A generic solution to the InjectContentScripts case will also apply to handleActivateScripts, so I did not add tests for that here. A test case for the dynamic code execution case is not part of this patch because the observed result would be that the test gets stuck. This test case will be included with the next patch that fixes this bug, which will also update the test expectation for the "UNEXPECTEDLY" never-settling promise mentioned above. Original Revision: https://phabricator.services.mozilla.com/D212986 Differential Revision: https://phabricator.services.mozilla.com/D214004
This patch fixes the issue by injecting immediately when a content script execution is scheduled for an initial about:blank document. This case is only reachable through dynamic content script execution APIs, and not through declarative content scripts. The latter is out of scope for this bug and tracked separately at bug 1415539 + bug 1486036. An alternative solution could have been to not inject, e.g. by ignoring the frame or throwing an error. This would however be unexpected to an an extension developer whose intention is to run a code snippet in all frames that are reachable by web pages (which works in Chrome). Original Revision: https://phabricator.services.mozilla.com/D212987 Differential Revision: https://phabricator.services.mozilla.com/D214005
…se-split mode a=RyanVM Original Revision: https://phabricator.services.mozilla.com/D213728 Differential Revision: https://phabricator.services.mozilla.com/D214169
Depends on D209355 Differential Revision: https://phabricator.services.mozilla.com/D209356
…S a=RyanVM This patch ensures that every button in the SelectTranslationsPanel can be invoked both with the Enter key or the space bar on all operating systems. Original Revision: https://phabricator.services.mozilla.com/D213635 Differential Revision: https://phabricator.services.mozilla.com/D213893
Splits up the tests for try-again-button keypresses in the SelectTranslationsPanel to avoid an intermittent test timeout failure in CI. Original Revision: https://phabricator.services.mozilla.com/D213765 Depends on D213893 Differential Revision: https://phabricator.services.mozilla.com/D213889
…yanVM Attempts to fix some of the Translations high-freq test failures that were introduced by Bug 1900023. Original Revision: https://phabricator.services.mozilla.com/D213849 Depends on D213889 Differential Revision: https://phabricator.services.mozilla.com/D213890
This patch ensures that the init-failure telemetry tests for the SelectTranslationsPanel properly await the "popupshown" event when the try-again button is pressed, since that re-opens the panel. Original Revision: https://phabricator.services.mozilla.com/D214056 Depends on D213890 Differential Revision: https://phabricator.services.mozilla.com/D214148
Adds the ability for the SelectTranslationsPanel to send telemetry events when the from-language or the to-language is changed in the panel such that a new translation is triggered. Original Revision: https://phabricator.services.mozilla.com/D214159 Differential Revision: https://phabricator.services.mozilla.com/D214194
Cleans up the definitions of the language extra_key values throughout Translations Telemetry to use references for all of the language keys that have the exact same definition. Original Revision: https://phabricator.services.mozilla.com/D214163 Differential Revision: https://phabricator.services.mozilla.com/D214195
Adds the ability for the SelectTranslationsPanel to send telemetry events when the source language is changed and a translation is requested from the unsupported-language view. Original Revision: https://phabricator.services.mozilla.com/D214160 Differential Revision: https://phabricator.services.mozilla.com/D214196
Adds the ability for the SelectTranslationsPanel to send to telemetry whether the source text came from an active selection or from a right-clicked hyperlink's text. Original Revision: https://phabricator.services.mozilla.com/D214161 Differential Revision: https://phabricator.services.mozilla.com/D214197
…anVM This patch allows the extensions success link to also be opened when the migration wizard is running in the spotlight. The issue seems to be that the browser element used in `OpenAboutAddons` doesn't exist when running in spotlight, so I've opted to instead allow the event to be handled with `OpenURL` when running in the aboutwelcome bundle, and also adding a parameter to handle trusted links with OpenURL. Original Revision: https://phabricator.services.mozilla.com/D213666 Differential Revision: https://phabricator.services.mozilla.com/D214182
…ar.js r=sidebar-reviewers,nsharpley a=test-only
…X-ANDROID_128_0_BUILD1 a=release CLOSED TREE DONTBUILD
…X_128_0_BUILD1 a=release CLOSED TREE DONTBUILD
…a=RyanVM Use 10s which feels it should be enough for geoclue to provide a reasonable location, without feeling too slow for users. Still if geoclue eventually gives us a proper location we'd update it properly and stop the network fallback so this seems reasonable. I made some naming tweaks for consistency but otherwise it should be reasonably straight-forward. Differential Revision: https://phabricator.services.mozilla.com/D215491
…ount is explicit or not. r=dholbert a=RyanVM This is needed because we want implicit width of number and text controls be the same, but explicit width be different to account for the spinners. See: data:text/html,<input type="number"><br><input type="text"><br><input type="number" min="1" max="9"><br><input type="text" size="1"> For example. This patch on its own shouldn't change behavior.
…lbert a=RyanVM See the previous patch commit message for the desired behavior. Keep non-explicit sizing working the same, but make explicit sizing account for the button box size. This matches other browsers, and generally makes sure that the specified number of columns fit. Unfortunately this is not testable by WPT because spinners are not cross-platform / specified anywhere, but I added a Gecko WPT.
…RyanVM We can't put it upstream because whether platforms have spinners is not defined (we only do that on android for example).
…encies plugin. r=android-reviewers,jonalmeida a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D214144
Split out from the other patch for readability. This doesn't change behavior but unifies where we store the buttons of number/search/password inputs.
Original Revision: https://phabricator.services.mozilla.com/D213425 Differential Revision: https://phabricator.services.mozilla.com/D215657
…ph.util.readonlydict.ReadOnlyDict', a=RyanVM Original Revision: https://phabricator.services.mozilla.com/D213426 Differential Revision: https://phabricator.services.mozilla.com/D215658
…kgraph.util.copy', a=RyanVM Original Revision: https://phabricator.services.mozilla.com/D213427 Differential Revision: https://phabricator.services.mozilla.com/D215659
…h.util.templates', a=RyanVM Original Revision: https://phabricator.services.mozilla.com/D213428 Differential Revision: https://phabricator.services.mozilla.com/D215660
Original Revision: https://phabricator.services.mozilla.com/D213429 Differential Revision: https://phabricator.services.mozilla.com/D215661
Make it a bit easier to follow / harder to mess up the specificity. The issue is that the lwtheme rule was more specific than the keyboard background since the regressing bug. Original Revision: https://phabricator.services.mozilla.com/D215381 Differential Revision: https://phabricator.services.mozilla.com/D215494
This change fixes a bug in the PPA API's that causes multiple source/target impressions not to store properly in the data store due to a promise being returned instead of the evaluation of the statement in the compareImpression function. This causes an issue where we cannot handle multiple ads / suppliers running at the same time. The plan is to release this in the Fx 128 release. Original Revision: https://phabricator.services.mozilla.com/D215656 Differential Revision: https://phabricator.services.mozilla.com/D215673
…=janerik,android-reviewers a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D214887
…CA users. r=adw a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D215699
|
Mozilla Releng Treescript seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version bump:
Firefox version 128.0 (cf0397e)
Compatible with Playwright patches for v1.48
Fixes #251