Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add various small bug fixes #406

Merged
merged 10 commits into from
Sep 2, 2024
Merged

Add various small bug fixes #406

merged 10 commits into from
Sep 2, 2024

Conversation

lauraschauer
Copy link
Contributor

@lauraschauer lauraschauer commented Aug 28, 2024

This PR fixes small bugs across Prospector:

  1. Sends one single update request to the DB to update the security_relevant field for all candidate commits instead of a request for each candidate individually
  2. Makes sure that security_relevant information is only retrieved when using backend is always or optional
  3. Makes parsing of LLM output more robus
  4. Cleaner error logging when git command fails and when invalid CVE ID is given
  5. Fixes bug extracting Jira issues from the XML content

…instead of sending a request for each individual commit)

adds LLM statistics to statistics object and
Prospector reports

Captures execution time at the level above the
LLMService function, so that even if LLM function
doesn't get executed anymore (because the
information is found in db), the time of the db
retrieval is still measured.
…it classification.

Now if there is 'true' or 'false' in the answer string, it is returned as True and False respectively, instead of checking for certain output formats
makes sure that only commits refrenced in the advisory with a commit hash are treated as 'fixing commits', and not if the references is eg. 'commit::master'
…eved when using backend is optional or always
@copernico copernico merged commit ebd9efb into SAP:main Sep 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants