Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support multi subaccount documentation #369

Closed
wants to merge 31 commits into from
Closed

support multi subaccount documentation #369

wants to merge 31 commits into from

Conversation

I065450
Copy link
Collaborator

@I065450 I065450 commented Nov 27, 2023

No description provided.

README.md Outdated
The association between a namespace and a subaccount is based on a different set of credentials configured for different namespaces.
## Working with Multiple Subaccounts

By default, a Kubernetes cluster is related to one subaccount (see step 4 of the [Setup](#setup) section.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

close parentheses

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

README.md Outdated
## Working with Multiple Subaccounts

By default, a Kubernetes cluster is related to one subaccount (see step 4 of the [Setup](#setup) section.
The SAP BTP service operator can also be configured to manage multiple subaccounts within a single Kubernetes cluster. In this more complex use case, each resource is linked to a specific subaccount using a unique set of credentials. To connect a resource to a subaccount:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the operator does not 'manage' subaccounts, but 'work with'. as described in the header of this section.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

README.md Outdated
## Working with Multiple Subaccounts

By default, a Kubernetes cluster is related to one subaccount (see step 4 of the [Setup](#setup) section.
The SAP BTP service operator can also be configured to manage multiple subaccounts within a single Kubernetes cluster. In this more complex use case, each resource is linked to a specific subaccount using a unique set of credentials. To connect a resource to a subaccount:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here we ignore the second level - associating an entire namespace to a subaccount.
e.g.,
"however, it is also possible to configure the SAP BTP service operator to work with more than one subaccount, either to connect an different namespaces to work with different subaccounts, and in more complex use cases, to create within the same namespace service instances in different subaccounts."
The configuration of working with multiple subaccounts is based on using a unique set of credentials, to connect with each subaccount:"

README.md Outdated

* Store these credentials securely in a secret.

You have several options at your disposal to manage multiple subaccounts in a cluster by configuring secrets on several levels:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

work with instead of manage.

BTW, this sentence is in a way redundant with the previous one. let's consider if it can be rearranged.

README.md Outdated
apiVersion: v1
kind: Secret
metadata:
name: sap-btp-service-operator-tls
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@I065450 @kerenlahav shall the secret name contain '-tls' suffix??

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the name must be sap-btp-service-operator-tls

README.md Outdated

**Note:**
The system's centrally-managed namespace is set by the value in `.Values.manager.management_namespace`. You can provide this value during installation (refer to step 4 in the [Setup](#setup) section).
If you don't specify this value, the system will use the installation namespace as the default.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the name of the installation namespace

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is given in the installation:
helm upgrade --install sap-btp-operator sap-btp-operator/sap-btp-operator
--create-namespace
--namespace=sap-btp-operator \

README.md Outdated
kind: Secret
metadata:
name: <namespace>-sap-btp-service-operator
namespace: centrally managed namespace
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be in brackets

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

sm_url: "<sm_url>"
tokenurl: "<auth_url>"
tokenurlsuffix: "/oauth/token"
```
Copy link
Contributor

@avilupu avilupu Jan 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a note that this is a sample with client secret credentials, but it can also be tls-based.

other option is to 'generalize' the sample

apiVersion: v1
kind: Secret
metadata:
name: -sap-btp-service-operator
namespace:
type: Opaque
data:
...
< credentials details here >
...

README.md Outdated

There are two options to maintain namespace-specific credentials, and they differ between default and TLS-based access credentials types:
You can associate a subaccount with a random or a centrally-managed namespace:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To associate namespace to a specific subaccount you have to maintain the access credentials to the subaccount in a secret which is dedicated for the specific namespace. Such secret can be located either in the namespace itself or in a centrally-managed namespace:

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

README.md Outdated
```
### 2. Explicit Secret Configuration

You can specify on the `ServiceInstance` level to which subaccount it should be associated:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"...in which subaccount it shall be created"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@kerenlahav kerenlahav closed this Jan 29, 2024
@I065450 I065450 deleted the multiSubaccount branch March 31, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants