better error message for invalid Service Manager credentials #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evyaffe
approved these changes
Dec 17, 2023
valiparsa
reviewed
Dec 27, 2023
| @@ -108,6 +108,12 @@ func (r *BaseReconciler) getSMClient(ctx context.Context, object api.SAPBTPResou | |||
| } | |||
| } | |||
|
|
|||
| if len(cfg.ClientID) == 0 || | |||
| len(cfg.ClientSecret) == 0 || | |||
There was a problem hiding this comment.
@kerenlahav this condition would always result in showing this error message invalid Service-Manager credentials, contact your cluster administrator when you don't create clientID and clientSecret servicekey but TLS based service key. In case of TLS based service key the cfg.ClientSecret is always empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
provide dedicated error message for invalid sm credentials