Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance support for plan unique identifier in entitlements #953

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

prajin-op
Copy link
Contributor

Purpose

Issue #930

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Test the code via automated test
go test ./...
  • Additional test steps
...

What to Check

Verify that the following are valid:

  • Automated tests are executed successfully
  • ...

Other Information

Checklist for reviewer

The following organizational tasks must be completed before merging this PR:

  • The PR is assigned to the Terraform project and a status is set (typically "in review").
  • The PR has the matching labels assigned to it.
  • The PR has a milestone assigned to it.
  • If the PR closes an issue, the issue is referenced.
  • Possible follow-up items are created and linked.

@prajin-op prajin-op added the enhancement New feature or request label Nov 18, 2024
@lechnerc77 lechnerc77 added this to the 1.9.0 milestone Nov 20, 2024
Copy link

github-actions bot commented Dec 7, 2024

This pull request is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale Marking a stale issue/PR due to inactivity label Dec 7, 2024
@prajin-op
Copy link
Contributor Author

The API throws a validation error when an invalid plan unique identifier is provided as input, and as a result, the service entitlement is not assigned. We are following up on this issue through the JIRA ticket mentioned below.
https://jira.tools.sap/browse/NGPBUG-410443

@lechnerc77 lechnerc77 removed the Stale Marking a stale issue/PR due to inactivity label Dec 10, 2024
Copy link

This pull request is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale Marking a stale issue/PR due to inactivity label Dec 26, 2024
@lechnerc77 lechnerc77 removed the Stale Marking a stale issue/PR due to inactivity label Dec 27, 2024
@lechnerc77 lechnerc77 modified the milestones: 1.9.0, 1.10.0 Jan 7, 2025
Copy link

This pull request is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale Marking a stale issue/PR due to inactivity label Jan 23, 2025
@prajin-op prajin-op removed the Stale Marking a stale issue/PR due to inactivity label Jan 23, 2025
Copy link

github-actions bot commented Feb 8, 2025

This pull request is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale Marking a stale issue/PR due to inactivity label Feb 8, 2025
@vipinvkmenon vipinvkmenon removed the Stale Marking a stale issue/PR due to inactivity label Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants