Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sbndcode version and add flash metrics #46

Open
wants to merge 1 commit into
base: release/v1_04_00
Choose a base branch
from

Conversation

wjdanswjddl
Copy link
Contributor

Description

changes:

  • update the product dependencies to use sbndaq_artdaq_core v1_10_03 via sbncode v09_93_01_02
  • new dqmAnalysis/BeamMetrics directory, which contains flash metrics for SBND

Related Repository Branches

List related branches from other repos here (links to PRs even better!), if not linked above.

Testing details

Tested online at SBND

Copy link

@lynnt20 lynnt20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, thank you @wjdanswjddl !!

Copy link
Member

@mvicenzi mvicenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is currently no tagged icaruscode version based on sbncode v09_93_01_02, so I currently can't test it, but the other changes are not affecting any ICARUS module so I'm approving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants