-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Get-GSChromeDeviceTelemetry #365
base: main
Are you sure you want to change the base?
Conversation
Added Get-GSChromeDeviceTelemetry Added ChromeMamnagement API to NuGetDependencies.json Updated Newtonsoft.Json version in NuGetDependencies.json to support the ChromeManagement API
Hey @Foggy2 this looks really good. I assume you've been able to test this yourself in your Org? I don't have access to Chrome devices in mine so I can't test it myself. |
Hey @FISHMANPET. Yes, I have been using this for the last couple weeks without issue. In the interests of consistency I would like your thoughts on the naming? I was unsure if I should call it We also already have a function `Get-GSChromeOSDevice' as an example too which is another variation on the naming convention. |
Naming can be tricky, especially with some of Google's APIs, but my opinion is that you've made the right choice here. While this is in the "Chrome" API, you're right this particular endpoint only applies to devices, so I think it makes sense to include it in the name. The other function uses the admin directory API and specifically returns an object of type As an example of the inconsistencies that appear in something as large as Google's APIs, here's something I came across a few years ago: The enums for two separate endpoints are different in .Net even though they're the same in the REST documentation: googleapis/google-api-dotnet-client#1593 So, I'd say what you've done is fine. If anything, there could be an argument that there should be an alias of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, sorry, one more thing I noticed as I was looking at this. Normally I'd just test this myself and figure out the answer but since I don't have access to this in my org I have to rely on someone else to test.
Added parameter $CustomerID
Added
Get-GSChromeDeviceTelemetry
Added ChromeMamnagement API to NuGetDependencies.json
Updated Newtonsoft.Json version in NuGetDependencies.json to support the ChromeManagement API
This will allow use of the customers.telemetry.devices method of the Chrome Management API.
Haven't done anything on this level before so let me know of any feedback.