feat: DAH-3083 remove preferences in DALP application summary (#2492)

* feat: DAH-3077 hide lottery prefs * feat: remove preferences section * fix: merge conflict * fix: controller * fix: ng-if function * test: update test --------- Co-authored-by: tallulah <[email protected]>
SFDigitalServices · Jan 22, 2025 · 5af3025 · 5af3025
1 parent c60b40b
commit 5af3025
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/app/assets/javascripts/short-form/components/application-summary.html.slim b/app/assets/javascripts/short-form/components/application-summary.html.slim
@@ -155,7 +155,7 @@ div ng-if="::$ctrl.application.householdIncome.incomeTotal"
       | {{::$ctrl.applicationIncomeAmount()}}
 
 / Preferences
-div ng-if="::!$ctrl.atAutofillPreview"
+div ng-if="::(!$ctrl.atAutofillPreview && !$ctrl.isDALPListing())"
   review-summary-section header="{{'label.preferences' | translate}}" section-name="{{::$ctrl.getStartOfSection({name: 'Preferences'})}}" editable="::$ctrl.sectionsAreEditable" edit-description="{{'label.edit_preferences' | translate}}"
   preferences-summary application="$ctrl.application" listing="$ctrl.listing" preferences="$ctrl.preferences"
 

diff --git a/app/assets/javascripts/short-form/components/applicationSummary.js.coffee b/app/assets/javascripts/short-form/components/applicationSummary.js.coffee
@@ -15,8 +15,8 @@ angular.module('dahlia.components')
     preferences: '<'
     showVeteransApplicationQuestion: '<'
   controller: [
-    '$filter', '$state', '$translate', 'LendingInstitutionService', 'ShortFormHelperService', 'ShortFormNavigationService', 'ShortFormRaceEthnicityService',
-    ($filter, $state, $translate, LendingInstitutionService, ShortFormHelperService, ShortFormNavigationService, ShortFormRaceEthnicityService) ->
+    '$filter', '$state', '$translate', 'LendingInstitutionService', 'ShortFormHelperService', 'ShortFormNavigationService', 'ShortFormRaceEthnicityService', 'ListingDataService',
+    ($filter, $state, $translate, LendingInstitutionService, ShortFormHelperService, ShortFormNavigationService, ShortFormRaceEthnicityService, ListingDataService) ->
       ctrl = @
 
       ctrl.$onInit = ->
@@ -133,5 +133,8 @@ angular.module('dahlia.components')
       ctrl.getIsNonPrimaryMemberVeteran = ->
         ctrl.translatedYesNoNoAnswer(ctrl.application.isNonPrimaryMemberVeteran)
 
+      ctrl.isDALPListing = ->
+        ListingDataService.listing.Custom_Listing_Type == 'Downpayment Assistance Loan Program'
+
       return ctrl
   ]
diff --git a/spec/javascripts/components/short-form/application_summary_spec.coffee b/spec/javascripts/components/short-form/application_summary_spec.coffee
@@ -38,6 +38,9 @@ do ->
       getStartOfSection: jasmine.createSpy()
     fakeShortFormRaceEthnicityService =
       salesforceToHumanReadable: jasmine.createSpy()
+    fakeListingDataService =
+      getListing: jasmine.createSpy()
+
     beforeEach module('dahlia.components')
     beforeEach module('customFilters', ($provide) ->)
 
@@ -55,6 +58,7 @@ do ->
         ShortFormHelperService: fakeShortFormHelperService
         ShortFormNavigationService: fakeShortFormNavigationService
         ShortFormRaceEthnicityService: fakeShortFormRaceEthnicityService
+        ListingDataService: fakeListingDataService
     )
 
     beforeEach ->