feat: DAH-2876 useRedirect for authenticated pages #2488

cade-exygy · 2025-01-07T20:06:13Z

Description

If a user tries to go to the my-account, account-settings, or my-applications and is not signed in: redirect to sign in page, show banner. Once the login happens, the user is redirected to the page they were trying to access prior.

Jira ticket

https://sfgovdt.jira.com/browse/DAH-2876

Checklist before requesting review

Version Control

branch name begins with angular if it contains updates to Angular code
branch name contains the Jira ticket number
PR name follows type: TICKET-NUMBER Description format, e.g. feat: DAH-123 New Feature

Code quality

the set of changes is small
all automated code checks pass (linting, tests, coverage, etc.)
code irrelevant to the ticket is not modified e.g. changing indentation due to automated formatting
if the code changes the UI, it matches the UI design exactly
if the changes include human translations, follow the human translations process

Review instructions

instructions specify which environment(s) it applies to
instructions work for PA testers
instructions have already been performed at least once

Request review

PR has needs review label
Use Housing Eng group to automatically assign reviewers, and/or assign specific engineers
If time sensitive, notify engineers in Slack

Review Instructions

On the review app:
While signed out, manually enter the restricted url: /my-account?react=true
It should try to load the page, but then redirect back to /sign-in
You should see the banner
Sign In to an account: [email protected] / test1234
Once you are signed in, you should be redirected
Try this with /my-account, /account-settings, and /my-applications

Test edge cases like signing out, triggering other banners, etc

app/javascript/pages/account/my-applications.tsx

app/javascript/hooks/useRedirect.tsx

app/javascript/pages/account/account-settings.tsx

jimlin-sfgov

these are just about coverage

app/javascript/hooks/useRedirect.tsx

jimlin-sfgov · 2025-01-14T07:19:53Z

app/javascript/util/routeUtil.ts

+
+export const getSignInRedirectUrl = (redirect: string) => {
+  return getRedirectUrl(redirect || "account")
+}


issue: Add tests for new functions in routeUtil.test.ts

app/javascript/authentication/SignInForm.tsx

tallulahkay

I tried to review this, but I'm still not seeing the banner pop up on the sign in page when i type in my-account?react=true

jimlin-sfgov · 2025-02-01T00:16:46Z

I don't see the banner when following the review instructions in the review app or locally. @cade-exygy did you run through your review instructions before requesting review?

cade-exygy · 2025-02-03T18:50:37Z

I don't see the banner when following the review instructions in the review app or locally. @cade-exygy did you run through your review instructions before requesting review?

@tallulahkay @jimlin-sfgov Added back the banner. FYI, the main changes here is the redirect logic, so looking for a review on that behavior.

tallulahkay

Nice!

app/javascript/__tests__/pages/account/account-settings.test.tsx

* feat: DAH-3077 hide lottery prefs * feat: remove preferences section * fix: merge conflict * fix: controller * fix: ng-if function * test: update test --------- Co-authored-by: tallulah <[email protected]>

…2510) fix: handle invalid listings when logging translation usage

* feat: remove back link on DALP listings * fix: try to address create account rtl failures * fix: remove test fix

Co-authored-by: Jim Lin <[email protected]>

* feat: DAH-3110 make enter submit * fix: DAH-3110 remove unnecessary changes * test: DAH-3110 add tests * test: DAH-3110 update snapshots * fix: DAH-3110 fix conflicting variable naming --------- Co-authored-by: Jim Lin <[email protected]>

…2517) * feat: DAH-3090 conditional check box review on dalp * feat: DAH-3090 dalp qualify conditional language * fix: DAH-3090 fix translations order * fix: DAH-3090 remove unneeded change

use localized sign in path

* feat: Analytics for log in and log out * fix: tests * test: improve test coverage * fix: fix some pr issues

* feat: add dalp check * fix: update check * fix: update check

fix: remove target blank

feat: add dalp priority to conf page

* fix: DAH-2866 fix formatting * fix: DAH-2866 fix in mobile

* feat: DAH-3084 confirmation page DALP * fix: DAH-3084 remove unneeded translation key * fix: DAH-3084 remove padding * fix: DAH-3084 link styling

* feat: DAH-3169 default to sf gov listing * test: DAH-3169 add test coverage * fix: DAH-3169 add localization to urls * fix: DAH-3169 try updating orb * test: DAH-3169 update e2e test * fix: DAH-3169 flip logic * test: DAH-3169 add existence check

* feat: DAH-3132 Update icon * fix: DAH-3132 fix debugging code

* feat: update dalp confirmation email * test: DAH-3085 fix test * feat: DAH-3085 add datetime * fix: DAH-3085 fix order of translations * test: DAH-3085 add test coverage * fix: DAH-3085 fix date string * fix: DAH-3085 a couple of formatting changes * test: DAH-3085 fix tests

* fix: DAH-3191 fix email address for lottery appeals * fix: DAH-3191 fix order of translations

…LP question (#2533)

* feat: add script * fix: sync with sforce

feat: DAH-2876 useRedirect for authenticated pages

99e823c

cade-exygy requested review from jimlin-sfgov and tallulahkay January 7, 2025 20:06

cade-exygy added the needs review Pull request needs review label Jan 7, 2025

hshaosf temporarily deployed to dahlia-webapp-pr-2488 January 7, 2025 20:07 Inactive

fix: translations

b97e876

cade-exygy temporarily deployed to dahlia-webapp-pr-2488 January 8, 2025 16:00 Inactive

cade-exygy temporarily deployed to dahlia-webapp-pr-2488 January 8, 2025 17:11 Inactive

jimlin-sfgov requested changes Jan 14, 2025

View reviewed changes

app/javascript/pages/account/my-applications.tsx Outdated Show resolved Hide resolved

app/javascript/hooks/useRedirect.tsx Outdated Show resolved Hide resolved

app/javascript/pages/account/account-settings.tsx Outdated Show resolved Hide resolved

jimlin-sfgov reviewed Jan 14, 2025

View reviewed changes

feat: use token for auth check

8e6a74b

cade-exygy temporarily deployed to dahlia-webapp-pr-2488 January 23, 2025 20:47 Inactive

feat: HOC withAuthentication

caba50e

cade-exygy temporarily deployed to dahlia-webapp-pr-2488 January 23, 2025 21:22 Inactive

clean: remove unused hook

a086a37

cade-exygy temporarily deployed to dahlia-webapp-pr-2488 January 23, 2025 21:31 Inactive

cade-exygy requested review from chadbrokaw and jimlin-sfgov January 30, 2025 18:00

fix: tests

1137a56

cade-exygy temporarily deployed to dahlia-webapp-pr-2488 January 31, 2025 17:57 Inactive

tallulahkay reviewed Jan 31, 2025

View reviewed changes

fix: add back banner

81eac08

cade-exygy temporarily deployed to dahlia-webapp-pr-2488 February 3, 2025 18:50 Inactive

tallulahkay approved these changes Feb 3, 2025

View reviewed changes

tallulahkay reviewed Feb 3, 2025

View reviewed changes

app/javascript/__tests__/pages/account/account-settings.test.tsx Outdated Show resolved Hide resolved

fix: tests

bbb4c2d

cade-exygy temporarily deployed to dahlia-webapp-pr-2488 February 3, 2025 19:09 Inactive

fix: test

a9c5089

cliu02 and others added 28 commits February 6, 2025 17:16

feat: DAH-3083 remove preferences in DALP application summary (#2492)

ae2151d

* feat: DAH-3077 hide lottery prefs * feat: remove preferences section * fix: merge conflict * fix: controller * fix: ng-if function * test: update test --------- Co-authored-by: tallulah <[email protected]>

fix: DAH-3181 Handle invalid listings when logging translation usage (#…

3f4f122

…2510) fix: handle invalid listings when logging translation usage

feat: DAH-3087 Remove back link on DALP listings (#2502)

4d60e84

* feat: remove back link on DALP listings * fix: try to address create account rtl failures * fix: remove test fix

fix: DAH-2865 translations fixes (#2473)

76af9f8

Co-authored-by: Jim Lin <[email protected]>

fix: DAH-2867 make height auto on my accounts dashboard (#2475)

413731c

Co-authored-by: Jim Lin <[email protected]>

fix: DAH-2868 status formatting (#2474)

5d4eb8c

Co-authored-by: Jim Lin <[email protected]>

fix: DAH-3158 open sections upon navigation (#2504)

8019dbe

Co-authored-by: Jim Lin <[email protected]>

feat: DAH-3110 make enter submit (#2479)

7dcb7ae

* feat: DAH-3110 make enter submit * fix: DAH-3110 remove unnecessary changes * test: DAH-3110 add tests * test: DAH-3110 update snapshots * fix: DAH-3110 fix conflicting variable naming --------- Co-authored-by: Jim Lin <[email protected]>

fix: DAH-3193 change naming (#2518)

822c2f1

feat: DAH-3090 DAH-3076 DALP Qualify Checkbox Conditional Language (#…

048e88b

…2517) * feat: DAH-3090 conditional check box review on dalp * feat: DAH-3090 dalp qualify conditional language * fix: DAH-3090 fix translations order * fix: DAH-3090 remove unneeded change

fix: DAH-3190 Use translations on confirmation modals (#2519)

fd3a3ca

use localized sign in path

feat: DAH-3055 Analytics for log in and log out (#2511)

0c92c8d

* feat: Analytics for log in and log out * fix: tests * test: improve test coverage * fix: fix some pr issues

feat: DAH-3080 DALP for My Applications page (#2509)

5048264

* feat: add dalp check * fix: update check * fix: update check

fix: DAH-3187 update FCFS how to apply link translations (#2513)

db30bc8

fix: remove target blank

feat: DAH-3091 Human Translations 2024-12-02 (#2514)

8c83653

feat: DAH-3082 add dalp priority to conf page (#2522)

4bc7026

feat: add dalp priority to conf page

fix: DAH-2866 fix formatting (#2476)

4543971

* fix: DAH-2866 fix formatting * fix: DAH-2866 fix in mobile

feat: DAH-3084 confirmation page DALP (#2521)

f3176b6

* feat: DAH-3084 confirmation page DALP * fix: DAH-3084 remove unneeded translation key * fix: DAH-3084 remove padding * fix: DAH-3084 link styling

feat: DAH-3074 DALP Application Question (#2530)

8bdbd54

urgent: upgdate circle config (#2534)

43b0289

feat: DAH-3132 Update icon (#2536)

492e08d

* feat: DAH-3132 Update icon * fix: DAH-3132 fix debugging code

fix: DAH-3191 fix email address for lottery appeals (#2540)

bba991f

* fix: DAH-3191 fix email address for lottery appeals * fix: DAH-3191 fix order of translations

feat: DAH-3201 Application Summary Edit button should take user to DA…

950eff2

…LP question (#2533)

feat: DAH-2826 Auto populate user (#2527)

60dd7dc

* feat: add script * fix: sync with sforce

fix: DAH-3207 Use NPM Chromedriver for Protractor (#2544)

af1e40e

fix: test conflicts

051e29f

cade-exygy temporarily deployed to dahlia-webapp-pr-2488 February 6, 2025 23:19 Inactive

cade-exygy closed this Feb 6, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: DAH-2876 useRedirect for authenticated pages #2488

feat: DAH-2876 useRedirect for authenticated pages #2488

cade-exygy commented Jan 7, 2025

jimlin-sfgov left a comment

jimlin-sfgov Jan 14, 2025 •

edited

Loading

tallulahkay left a comment

jimlin-sfgov commented Feb 1, 2025

cade-exygy commented Feb 3, 2025

tallulahkay left a comment

feat: DAH-2876 useRedirect for authenticated pages #2488

feat: DAH-2876 useRedirect for authenticated pages #2488

Conversation

cade-exygy commented Jan 7, 2025

Description

Jira ticket

Checklist before requesting review

Version Control

Code quality

Review instructions

Request review

Review Instructions

jimlin-sfgov left a comment

Choose a reason for hiding this comment

jimlin-sfgov Jan 14, 2025 • edited Loading

Choose a reason for hiding this comment

tallulahkay left a comment

Choose a reason for hiding this comment

jimlin-sfgov commented Feb 1, 2025

cade-exygy commented Feb 3, 2025

tallulahkay left a comment

Choose a reason for hiding this comment

jimlin-sfgov Jan 14, 2025 •

edited

Loading