Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DAH-3190 Use translations on confirmation modals #2519

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

chadbrokaw
Copy link
Collaborator

@chadbrokaw chadbrokaw commented Jan 28, 2025

Description

This ticket fixes an issue where clicking to create an account on a non-english page did not redirect the user to the same language page. This ticket also incorporates all the latest translations changes.

Jira ticket

https://sfgovdt.jira.com/browse/DAH-3190

Before requesting eng review

Version Control

  • branch name begins with angular if it contains updates to Angular code
  • branch name contains the Jira ticket number
  • PR name follows type: TICKET-NUMBER Description format, e.g. feat: DAH-123 New Feature. If the PR is urgent and does not need a ticket then use the format urgent: Description

Code quality

  • the set of changes is small
  • all automated code checks pass (linting, tests, coverage, etc.)
  • code irrelevant to the ticket is not modified e.g. changing indentation due to automated formatting
  • if the code changes the UI, it matches the UI design exactly

Review instructions

  • instructions specify which environment(s) it applies to
  • instructions work for PA testers
  • instructions have already been performed at least once

Request eng review

  • PR has needs review label
  • Use Housing Eng group to automatically assign reviewers, and/or assign specific engineers
  • If time sensitive, notify engineers in Slack

Before merging

Request product acceptance testing

  • Code change is behind a feature flag
  • If code change is not behind a feature flag, it has been PA tested in the review environment (use needs product acceptance label to indicate that the PR is waiting for PA testing)

@hshaosf hshaosf temporarily deployed to dahlia-webapp-pr-2519 January 28, 2025 14:41 Inactive
@chadbrokaw chadbrokaw force-pushed the DAH-3190_use_translations_on_confirmation_modals branch from f7617a4 to dd27a74 Compare January 28, 2025 15:40
@chadbrokaw chadbrokaw temporarily deployed to dahlia-webapp-pr-2519 January 28, 2025 15:40 Inactive
@chadbrokaw chadbrokaw requested review from a team, cliu02 and jimlin-sfgov and removed request for a team January 28, 2025 15:42
@chadbrokaw chadbrokaw marked this pull request as ready for review January 28, 2025 15:42
@chadbrokaw chadbrokaw added the needs review Pull request needs review label Jan 28, 2025
Copy link
Collaborator

@jimlin-sfgov jimlin-sfgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chadbrokaw chadbrokaw force-pushed the DAH-3190_use_translations_on_confirmation_modals branch from dd27a74 to 1305272 Compare January 28, 2025 20:05
@chadbrokaw chadbrokaw temporarily deployed to dahlia-webapp-pr-2519 January 28, 2025 20:05 Inactive
@chadbrokaw chadbrokaw merged commit 85dc8ee into main Jan 28, 2025
19 checks passed
@chadbrokaw chadbrokaw deleted the DAH-3190_use_translations_on_confirmation_modals branch January 28, 2025 20:36
cade-exygy pushed a commit that referenced this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review Pull request needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants