Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DAH-3055 Send user id and timestamp with every push #2520

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chadbrokaw
Copy link
Collaborator

@chadbrokaw chadbrokaw commented Jan 28, 2025

Description

The user_id and timestamp will now be sent with every event. In the case that the user is not signed in, we will send undefined for the user_id value. This will allow us to have more information about user behavior and leverage GA's user_id tracking feature.

Jira ticket

https://sfgovdt.jira.com/browse/DAH-3052

Before requesting eng review

Version Control

  • branch name begins with angular if it contains updates to Angular code
  • branch name contains the Jira ticket number
  • PR name follows type: TICKET-NUMBER Description format, e.g. feat: DAH-123 New Feature. If the PR is urgent and does not need a ticket then use the format urgent: Description

Code quality

  • the set of changes is small
  • all automated code checks pass (linting, tests, coverage, etc.)
  • code irrelevant to the ticket is not modified e.g. changing indentation due to automated formatting
  • if the code changes the UI, it matches the UI design exactly

Review instructions

  • instructions specify which environment(s) it applies to
  • instructions work for PA testers
  • instructions have already been performed at least once

Request eng review

  • PR has needs review label
  • Use Housing Eng group to automatically assign reviewers, and/or assign specific engineers
  • If time sensitive, notify engineers in Slack

Before merging

Request product acceptance testing

  • Code change is behind a feature flag
  • If code change is not behind a feature flag, it has been PA tested in the review environment (use needs product acceptance label to indicate that the PR is waiting for PA testing)

@hshaosf hshaosf temporarily deployed to dahlia-webapp-pr-2520 January 28, 2025 20:45 Inactive
@chadbrokaw chadbrokaw requested review from a team, cliu02 and alulabeshue-sfgov and removed request for a team January 28, 2025 21:20
@chadbrokaw chadbrokaw added the needs review Pull request needs review label Jan 28, 2025
@chadbrokaw chadbrokaw force-pushed the DAH-3055_Accounts_analytics_events branch from 8ef2fac to 72595e3 Compare January 29, 2025 14:38
Base automatically changed from DAH-3055_Accounts_analytics_events to main January 29, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review Pull request needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants