Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DAH-3102 DALP on Sales Directory #2524

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

cliu02
Copy link
Collaborator

@cliu02 cliu02 commented Jan 29, 2025

Description

Restore the old DALP card to the sales directory header with new content.

Jira ticket

https://sfgovdt.jira.com/browse/DAH-3102

Before requesting eng review

Version Control

  • branch name begins with angular if it contains updates to Angular code
  • branch name contains the Jira ticket number
  • PR name follows type: TICKET-NUMBER Description format, e.g. feat: DAH-123 New Feature. If the PR is urgent and does not need a ticket then use the format urgent: Description

Code quality

  • the set of changes is small
  • all automated code checks pass (linting, tests, coverage, etc.)
  • code irrelevant to the ticket is not modified e.g. changing indentation due to automated formatting
  • if the code changes the UI, it matches the UI design exactly

Review instructions

  • instructions specify which environment(s) it applies to
  • instructions work for PA testers
  • instructions have already been performed at least once

Request eng review

  • PR has needs review label
  • Use Housing Eng group to automatically assign reviewers, and/or assign specific engineers
  • If time sensitive, notify engineers in Slack

Before merging

Request product acceptance testing

  • Code change is behind a feature flag
  • If code change is not behind a feature flag, it has been PA tested in the review environment (use needs product acceptance label to indicate that the PR is waiting for PA testing)

@hshaosf hshaosf temporarily deployed to dahlia-webapp-pr-2524 January 29, 2025 18:40 Inactive
@cliu02 cliu02 marked this pull request as ready for review January 29, 2025 18:46
@cliu02 cliu02 added the needs review Pull request needs review label Jan 29, 2025
@cliu02 cliu02 requested review from a team, chadbrokaw and tallulahkay and removed request for a team January 29, 2025 18:46
<p className="mb-4">
{renderInlineMarkup(
t("saleDirectory.dalp.link", {
url: "https://www.sf.gov/apply-downpayment-loan-buy-market-rate-home",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: waiting on decision for how to implement non-English sf.gov link redirects

Copy link
Contributor

@tallulahkay tallulahkay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! I think we can merge this and handle all the link localization things in a follow up ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review Pull request needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants