Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DAH-3200 update broken sf.gov link redirects #2528

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

cliu02
Copy link
Collaborator

@cliu02 cliu02 commented Jan 30, 2025

Description

Use new Karl pattern for sf.gov links in non-English languages.

Jira ticket

https://sfgovdt.jira.com/browse/DAH-3200

Before requesting eng review

Version Control

  • branch name begins with angular if it contains updates to Angular code
  • branch name contains the Jira ticket number
  • PR name follows type: TICKET-NUMBER Description format, e.g. feat: DAH-123 New Feature. If the PR is urgent and does not need a ticket then use the format urgent: Description

Code quality

  • the set of changes is small
  • all automated code checks pass (linting, tests, coverage, etc.)
  • code irrelevant to the ticket is not modified e.g. changing indentation due to automated formatting
  • if the code changes the UI, it matches the UI design exactly

Review instructions

  • instructions specify which environment(s) it applies to
  • instructions work for PA testers
  • instructions have already been performed at least once

Request eng review

  • PR has needs review label
  • Use Housing Eng group to automatically assign reviewers, and/or assign specific engineers
  • If time sensitive, notify engineers in Slack

Before merging

Request product acceptance testing

  • Code change is behind a feature flag
  • If code change is not behind a feature flag, it has been PA tested in the review environment (use needs product acceptance label to indicate that the PR is waiting for PA testing)

@hshaosf hshaosf temporarily deployed to dahlia-webapp-pr-2528 January 30, 2025 22:06 Inactive
@cliu02 cliu02 marked this pull request as ready for review January 30, 2025 22:49
@cliu02 cliu02 added the needs review Pull request needs review label Jan 30, 2025
@cliu02 cliu02 temporarily deployed to dahlia-webapp-pr-2528 January 30, 2025 22:49 Inactive
@cliu02 cliu02 requested review from a team, cade-exygy and alulabeshue-sfgov and removed request for a team January 30, 2025 22:49
@jimlin-sfgov
Copy link
Collaborator

jimlin-sfgov commented Jan 31, 2025

@cliu02 I did a quick spot check and this link exhibits weird behavior that may require collaboration with DDS engineers working on the Karl migration:

Can you be thorough and check all of the links in this PR for irregularities?

Edit: I checked again and the redirect for that link is working as expected.

@cliu02 cliu02 temporarily deployed to dahlia-webapp-pr-2528 January 31, 2025 03:59 Inactive
@jimlin-sfgov
Copy link
Collaborator

I've realized there are a few https://sf.gov/node/... urls in the Angular part of codebase. It would be nice to update those in this PR as well (no language switching logic is needed though)

@cliu02 cliu02 temporarily deployed to dahlia-webapp-pr-2528 February 3, 2025 20:48 Inactive
@jimlin-sfgov jimlin-sfgov self-requested a review February 3, 2025 20:50
Copy link
Collaborator

@jimlin-sfgov jimlin-sfgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cliu02 cliu02 added needs product acceptance Pull request requires product acceptance before merging and removed needs review Pull request needs review labels Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs product acceptance Pull request requires product acceptance before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants