-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: DAH-3200 update broken sf.gov link redirects #2528
base: main
Are you sure you want to change the base?
Conversation
@cliu02
Edit: I checked again and the redirect for that link is working as expected. |
I've realized there are a few |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Use new Karl pattern for sf.gov links in non-English languages.
Jira ticket
https://sfgovdt.jira.com/browse/DAH-3200
Before requesting eng review
Version Control
angular
if it contains updates to Angular codetype: TICKET-NUMBER Description
format, e.g.feat: DAH-123 New Feature
. If the PR is urgent and does not need a ticket then use the formaturgent: Description
Code quality
Review instructions
Request eng review
needs review
labelHousing Eng
group to automatically assign reviewers, and/or assign specific engineersBefore merging
Request product acceptance testing
needs product acceptance
label to indicate that the PR is waiting for PA testing)