-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: DAH-3085 DALP confirmation email #2531
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jimlin-sfgov good eye and thanks for reviewing! You're right - Bridget confirmed that we should remove the hello and signature |
5aeffad
to
d37fa9a
Compare
@jimlin-sfgov fixed what you noticed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Update the DALP confirmation email!
Jira ticket
https://sfgovdt.jira.com/browse/DAH-3085
Before requesting eng review
Version Control
angular
if it contains updates to Angular codetype: TICKET-NUMBER Description
format, e.g.feat: DAH-123 New Feature
. If the PR is urgent and does not need a ticket then use the formaturgent: Description
Code quality
Review instructions
Request eng review
needs review
labelHousing Eng
group to automatically assign reviewers, and/or assign specific engineersBefore merging
Request product acceptance testing
needs product acceptance
label to indicate that the PR is waiting for PA testing)