Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DAH-3085 DALP confirmation email #2531

Merged
merged 9 commits into from
Feb 5, 2025

Conversation

tallulahkay
Copy link
Contributor

@tallulahkay tallulahkay commented Jan 31, 2025

Description

Update the DALP confirmation email!

Jira ticket

https://sfgovdt.jira.com/browse/DAH-3085

Before requesting eng review

Version Control

  • branch name begins with angular if it contains updates to Angular code
  • branch name contains the Jira ticket number
  • PR name follows type: TICKET-NUMBER Description format, e.g. feat: DAH-123 New Feature. If the PR is urgent and does not need a ticket then use the format urgent: Description

Code quality

  • the set of changes is small
  • all automated code checks pass (linting, tests, coverage, etc.)
  • code irrelevant to the ticket is not modified e.g. changing indentation due to automated formatting
  • if the code changes the UI, it matches the UI design exactly

Review instructions

  • instructions specify which environment(s) it applies to
  • instructions work for PA testers
  • instructions have already been performed at least once

Request eng review

  • PR has needs review label
  • Use Housing Eng group to automatically assign reviewers, and/or assign specific engineers
  • If time sensitive, notify engineers in Slack

Before merging

Request product acceptance testing

  • Code change is behind a feature flag
  • If code change is not behind a feature flag, it has been PA tested in the review environment (use needs product acceptance label to indicate that the PR is waiting for PA testing)

@tallulahkay tallulahkay changed the title Angular/dah 3085 dalp confirmation email feat: DAH-3085 DALP confirmation email Jan 31, 2025
@tallulahkay tallulahkay temporarily deployed to dahlia-webapp-pr-2531 January 31, 2025 20:29 Inactive
@tallulahkay tallulahkay requested review from a team, cliu02 and cade-exygy and removed request for a team January 31, 2025 20:33
@tallulahkay tallulahkay added the needs review Pull request needs review label Jan 31, 2025
@tallulahkay tallulahkay temporarily deployed to dahlia-webapp-pr-2531 January 31, 2025 20:34 Inactive
@tallulahkay tallulahkay temporarily deployed to dahlia-webapp-pr-2531 January 31, 2025 20:45 Inactive
@tallulahkay tallulahkay marked this pull request as ready for review January 31, 2025 20:51
@tallulahkay tallulahkay temporarily deployed to dahlia-webapp-pr-2531 January 31, 2025 21:01 Inactive
@tallulahkay tallulahkay temporarily deployed to dahlia-webapp-pr-2531 January 31, 2025 22:26 Inactive
Copy link
Collaborator

@jimlin-sfgov jimlin-sfgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if these are blockers:

  • there's still extra space below "After the lottery", maybe top margin from ul element?
  • there's a "Hello" header and "Thank you,..." footer from app/views/layouts/email.html.slim
Screenshot 2025-02-05 at 6 42 33 AM

@tallulahkay
Copy link
Contributor Author

@jimlin-sfgov good eye and thanks for reviewing! You're right - Bridget confirmed that we should remove the hello and signature

@tallulahkay tallulahkay temporarily deployed to dahlia-webapp-pr-2531 February 5, 2025 00:19 Inactive
@tallulahkay tallulahkay temporarily deployed to dahlia-webapp-pr-2531 February 5, 2025 00:28 Inactive
@tallulahkay tallulahkay force-pushed the angular/DAH-3085-dalp-confirmation-email branch from 5aeffad to d37fa9a Compare February 5, 2025 00:28
@tallulahkay tallulahkay temporarily deployed to dahlia-webapp-pr-2531 February 5, 2025 00:28 Inactive
@tallulahkay
Copy link
Contributor Author

@jimlin-sfgov fixed what you noticed!

Copy link
Collaborator

@jimlin-sfgov jimlin-sfgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tallulahkay tallulahkay temporarily deployed to dahlia-webapp-pr-2531 February 5, 2025 19:24 Inactive
@tallulahkay tallulahkay merged commit b111529 into main Feb 5, 2025
20 of 21 checks passed
@tallulahkay tallulahkay deleted the angular/DAH-3085-dalp-confirmation-email branch February 5, 2025 20:35
cade-exygy pushed a commit that referenced this pull request Feb 6, 2025
* feat: update dalp confirmation email

* test: DAH-3085 fix test

* feat: DAH-3085 add datetime

* fix: DAH-3085 fix order of translations

* test: DAH-3085 add test coverage

* fix: DAH-3085 fix date string

* fix: DAH-3085 a couple of formatting changes

* test: DAH-3085 fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review Pull request needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants