-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: DAH-3165 Use DALP lottery results URL for DALP applications #2541
Conversation
2f623b7
to
2c7352b
Compare
@@ -161,6 +172,15 @@ const ApplicationItem = (props: ApplicationItemProps) => { | |||
{t("listings.lottery.viewLotteryResults")} | |||
</Button> | |||
))} | |||
{props.submitted && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't quite work right - it appends the link to the end of the url and then redirects to home bc the path doesn't exist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: link doesn't work on button
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works now!
Description
On the My Applications page, link to sf.gov web page for DALP applications.
Jira ticket
https://sfgovdt.jira.com/browse/DAH-3165
Before requesting eng review
Version Control
angular
if it contains updates to Angular codetype: TICKET-NUMBER Description
format, e.g.feat: DAH-123 New Feature
. If the PR is urgent and does not need a ticket then use the formaturgent: Description
Code quality
Review instructions
Request eng review
needs review
labelHousing Eng
group to automatically assign reviewers, and/or assign specific engineersBefore merging
Request product acceptance testing
needs product acceptance
label to indicate that the PR is waiting for PA testing)