Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DAH-3165 Use DALP lottery results URL for DALP applications #2541

Merged
merged 4 commits into from
Feb 10, 2025

Conversation

jimlin-sfgov
Copy link
Collaborator

@jimlin-sfgov jimlin-sfgov commented Feb 5, 2025

Description

On the My Applications page, link to sf.gov web page for DALP applications.

Jira ticket

https://sfgovdt.jira.com/browse/DAH-3165

Before requesting eng review

Version Control

  • branch name begins with angular if it contains updates to Angular code
  • branch name contains the Jira ticket number
  • PR name follows type: TICKET-NUMBER Description format, e.g. feat: DAH-123 New Feature. If the PR is urgent and does not need a ticket then use the format urgent: Description

Code quality

  • the set of changes is small
  • all automated code checks pass (linting, tests, coverage, etc.)
  • code irrelevant to the ticket is not modified e.g. changing indentation due to automated formatting
  • if the code changes the UI, it matches the UI design exactly

Review instructions

  • instructions specify which environment(s) it applies to
  • instructions work for PA testers
  • instructions have already been performed at least once

Request eng review

  • PR has needs review label
  • Use Housing Eng group to automatically assign reviewers, and/or assign specific engineers
  • If time sensitive, notify engineers in Slack

Before merging

Request product acceptance testing

  • Code change is behind a feature flag
  • If code change is not behind a feature flag, it has been PA tested in the review environment (use needs product acceptance label to indicate that the PR is waiting for PA testing)

@hshaosf hshaosf temporarily deployed to dahlia-webapp-pr-2541 February 5, 2025 00:40 Inactive
@jimlin-sfgov jimlin-sfgov force-pushed the DAH-3165-dalp-lottery-results-link branch from 2f623b7 to 2c7352b Compare February 5, 2025 01:30
@jimlin-sfgov jimlin-sfgov temporarily deployed to dahlia-webapp-pr-2541 February 5, 2025 01:30 Inactive
@jimlin-sfgov jimlin-sfgov marked this pull request as ready for review February 5, 2025 01:31
@jimlin-sfgov jimlin-sfgov requested review from a team, tallulahkay and alulabeshue-sfgov and removed request for a team February 5, 2025 01:45
@jimlin-sfgov jimlin-sfgov added the needs review Pull request needs review label Feb 5, 2025
@@ -161,6 +172,15 @@ const ApplicationItem = (props: ApplicationItemProps) => {
{t("listings.lottery.viewLotteryResults")}
</Button>
))}
{props.submitted &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't quite work right - it appends the link to the end of the url and then redirects to home bc the path doesn't exist

Copy link
Contributor

@tallulahkay tallulahkay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: link doesn't work on button

Copy link
Contributor

@tallulahkay tallulahkay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works now!

@jimlin-sfgov jimlin-sfgov added needs product acceptance Pull request requires product acceptance before merging and removed needs review Pull request needs review labels Feb 5, 2025
@jimlin-sfgov jimlin-sfgov temporarily deployed to dahlia-webapp-pr-2541 February 10, 2025 20:06 Inactive
@jimlin-sfgov jimlin-sfgov temporarily deployed to dahlia-webapp-pr-2541 February 10, 2025 21:18 Inactive
@jimlin-sfgov jimlin-sfgov merged commit 32ca6de into main Feb 10, 2025
20 checks passed
@jimlin-sfgov jimlin-sfgov deleted the DAH-3165-dalp-lottery-results-link branch February 10, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs product acceptance Pull request requires product acceptance before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants