-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: DAH-3207 Use NPM Chromedriver for Protractor #2544
Conversation
@@ -1,6 +1,8 @@ | |||
var config = require('./conf-shared') | |||
|
|||
config.baseUrl = 'http://localhost:3000/' | |||
// chromedriver version in package.json should match chrome version installed by .circleci/config.yml | |||
config.chromeDriver = '../../node_modules/chromedriver/bin/chromedriver', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: we have to resort to using NPM's chromedriver because protractor only has access to these versions, which do not include the latest version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re ran tests as part of review steps: looks like the chrome issue is resolved, but other flakiness happening. If that is consistent with what you are expecting then the changes look good to me!
Yeah, back to our regularly scheduled flakiness, instead of consistently failing due to timeouts |
Description
Use newer chromedriver for Protractor to match updated Chrome browser version used by CircleCI orb.
Jira ticket
https://sfgovdt.jira.com/browse/DAH-3207
Before requesting eng review
Version Control
angular
if it contains updates to Angular codetype: TICKET-NUMBER Description
format, e.g.feat: DAH-123 New Feature
. If the PR is urgent and does not need a ticket then use the formaturgent: Description
Code quality
Review instructions
Request eng review
needs review
labelHousing Eng
group to automatically assign reviewers, and/or assign specific engineersBefore merging
Request product acceptance testing
needs product acceptance
label to indicate that the PR is waiting for PA testing)