Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DAH-3208 Change Home SF name #2545

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chadbrokaw
Copy link
Collaborator

@chadbrokaw chadbrokaw commented Feb 6, 2025

Description

Changes the HomeownershipSF name to be HomeSF and updates the url and email.

Jira ticket

https://sfgovdt.jira.com/browse/DAH-3208

Before requesting eng review

Version Control

  • branch name begins with angular if it contains updates to Angular code
  • branch name contains the Jira ticket number
  • PR name follows type: TICKET-NUMBER Description format, e.g. feat: DAH-123 New Feature. If the PR is urgent and does not need a ticket then use the format urgent: Description

Code quality

  • the set of changes is small
  • all automated code checks pass (linting, tests, coverage, etc.)
  • code irrelevant to the ticket is not modified e.g. changing indentation due to automated formatting
  • if the code changes the UI, it matches the UI design exactly

Review instructions

  • instructions specify which environment(s) it applies to
  • instructions work for PA testers
  • instructions have already been performed at least once

Request eng review

  • PR has needs review label
  • Use Housing Eng group to automatically assign reviewers, and/or assign specific engineers
  • If time sensitive, notify engineers in Slack

Before merging

Request product acceptance testing

  • Code change is behind a feature flag
  • If code change is not behind a feature flag, it has been PA tested in the review environment (use needs product acceptance label to indicate that the PR is waiting for PA testing)

@chadbrokaw chadbrokaw added the needs review Pull request needs review label Feb 6, 2025
@chadbrokaw chadbrokaw requested review from cliu02, a team and tallulahkay and removed request for a team February 6, 2025 16:00
@hshaosf hshaosf temporarily deployed to dahlia-webapp-pr-2545 February 6, 2025 16:01 Inactive
@chadbrokaw chadbrokaw force-pushed the DAH-3208_change_home_sf_name branch from 326aa3a to 9656407 Compare February 6, 2025 19:49
@chadbrokaw chadbrokaw temporarily deployed to dahlia-webapp-pr-2545 February 6, 2025 19:49 Inactive
@chadbrokaw chadbrokaw force-pushed the DAH-3208_change_home_sf_name branch from 9656407 to 30fb254 Compare February 6, 2025 22:04
@chadbrokaw chadbrokaw added needs product acceptance Pull request requires product acceptance before merging and removed needs review Pull request needs review labels Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs product acceptance Pull request requires product acceptance before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants