Skip to content
checks

feat: fix department ui translation issues #765

Sign in to view logs

feat: fix department ui translation issues

feat: fix department ui translation issues #765

Triggered via pull request April 25, 2024 14:47
@Daltyn06Daltyn06
opened #1672
SG-2045
Status Success
Total duration 53s
Artifacts –

checks.yml

on: pull_request
checks
43s
checks
Fit to window
Zoom out
Zoom in

Annotations

11 warnings
checks
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
checks: web/themes/custom/sfgovpl/src/js/back-to-top.js#L10
Expected method shorthand
checks: web/themes/custom/sfgovpl/src/js/back-to-top.js#L12
No magic number: 300
checks: web/themes/custom/sfgovpl/src/js/back-to-top.js#L24
No magic number: 700
checks: web/themes/custom/sfgovpl/src/js/back-to-top.js#L26
Closing curly brace appears on the same line as the subsequent block
checks: web/themes/custom/sfgovpl/src/js/campaign.js#L7
No magic number: 768
checks: web/themes/custom/sfgovpl/src/js/components.js#L7
Unexpected console statement
checks: web/themes/custom/sfgovpl/src/js/data-story.js#L38
No magic number: 700
checks: web/themes/custom/sfgovpl/src/js/data-story.js#L52
No magic number: 1000
checks: web/themes/custom/sfgovpl/src/js/dept-homepage.js#L4
No magic number: 300
checks: web/themes/custom/sfgovpl/src/js/instagram-feed.js#L8
Identifier 'paragraph_id' is not in camel case