Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify C++17 requirement explicitly #59

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Specify C++17 requirement explicitly #59

merged 1 commit into from
Jan 15, 2025

Conversation

eXpl0it3r
Copy link
Member

While I guess it's implicitly set by using SFML, it makes sense to have this option explicitly set on the target executable.

@eXpl0it3r eXpl0it3r added the enhancement New feature or request label Jan 14, 2025
@ChrisThrasher
Copy link
Member

Given that the executable already inherits this requirements from SFML’s CMake targets, what do we gain by repeating it explicitly?

@eXpl0it3r
Copy link
Member Author

eXpl0it3r commented Jan 14, 2025

That it is explicit.

If someone switch to find_package stuff suddenly breaks, even though this should largely be interchangeable.
Personally, I'd never write my own application that I know uses C++17 and not specify that in my own CMake file, just because it's already implicitly imported from some library.

@ChrisThrasher
Copy link
Member

Switching to find_package won’t break this either. No matter how you link to our CMake targets you’ll inherit this requirement. You’d have to modify this script very heavily for this to become a problem. That being said this is an innocuous change and it makes it marginally easier to upgrade to C++20 so I’m fine with it.

@eXpl0it3r eXpl0it3r merged commit 11ce8dc into master Jan 15, 2025
20 checks passed
@eXpl0it3r eXpl0it3r deleted the feature/cpp17 branch January 15, 2025 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants