Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapping updateMouseCursor() behind a dirty flag, like other example backends. Fixes the window resize cursor not being shown. #193

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

lucasz93
Copy link
Contributor

@lucasz93 lucasz93 commented Feb 3, 2022

As described in https://en.sfml-dev.org/forums/index.php?topic=27180.0 and #119.

updateMouseCursor was being spammed every tick which wasn't letting Windows temporarily override the IMGUI's cursor with the resize cursor. Other backends (like the Win32 one) wrap their equivalent of updateMouseCursor behind a dirty flag.

…backends. Fixes the window resize cursor not being shown.
@lucasz93 lucasz93 changed the title Wrapping updateMouseCursor() behind a dirty flag, like other example …backends. Fixes the window resize cursor not being shown. Wrapping updateMouseCursor() behind a dirty flag, like other example backends. Fixes the window resize cursor not being shown. Feb 3, 2022
@eliasdaler
Copy link
Contributor

Hello.
Thank you for the PR! Sorry it took me so long to get to it.

@eliasdaler eliasdaler merged commit 8faa79d into SFML:master Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants