Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding some schema validation and implementing tests for them #495

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

dr-rodriguez
Copy link
Collaborator

This is a general enhancement of the schema by adding a few validation functions and establishing tests for them.

Copy link
Collaborator

@kelle kelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the schema_tester function and I worry that we're adding too much complexity to our test suite. Let's discuss on Tuesday.

simple/schema.py Show resolved Hide resolved
simple/schema.py Show resolved Hide resolved
@kelle
Copy link
Collaborator

kelle commented Apr 30, 2024

We've discussed and I like it now!

@dr-rodriguez
Copy link
Collaborator Author

This relates to discussion at astrodbtoolkit/astrodb_utils#43

@dr-rodriguez dr-rodriguez merged commit 0d1f28f into SIMPLE-AstroDB:main Apr 30, 2024
1 check passed
@dr-rodriguez dr-rodriguez deleted the schema_testing branch April 30, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants