[feat] subject screen ui구현 #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l2zh
reviewed
Jan 19, 2025
|
|
||
| init { | ||
| setEvent(SubjectContract.SubjectEvent.Initialize) | ||
| } |
|
|
||
| override fun handleEvent(event: SubjectContract.SubjectEvent) { | ||
| when (event) { | ||
| is SubjectContract.SubjectEvent.Initialize -> {} |
| subjectId = 5, | ||
| examRemainingDays = 1, | ||
| ), | ||
| ), |
There was a problem hiding this comment.
p5: 더미 반복문으로 넣는거에 익숙해져 보면 좋을것 같아요
| } else if (height == 0) { | ||
| Spacer(modifier = Modifier.width(width.dp)) | ||
| } | ||
| } |
There was a problem hiding this comment.
p5 : 이미 Spacer로 맞춰서 쓰고 있던걸로 아는데 지금 추가한 이유가 있을까요?
l2zh
reviewed
Jan 19, 2025
Comment on lines
+57
to
+65
| subjectList = | ||
| state.subjectList.map { item -> | ||
| if (item.state == BbangZipCardState.CHECKABLE && item.subjectId == reduce.subjectId) { | ||
| item.copy(state = BbangZipCardState.CHECKED) | ||
| } else if (item.state == BbangZipCardState.CHECKED && item.subjectId == reduce.subjectId) { | ||
| item.copy(state = BbangZipCardState.CHECKABLE) | ||
| } else { | ||
| item | ||
| } |
There was a problem hiding this comment.
p5: 최적화를 할 수 있다면 어떤 부분에서 가능할까요? (힌트 : map)
지금 하라는거 아닙니다~
|
서버에서도 FetchType.Lazy 가 비슷하게 있는데 LazyColumn에서의 Lazy 개념도 '필요한 것만 가져와서 사용한다' -> 성능 개선 ! 카드 높이가 다른 이유는.. 승범씨와 코드가 달라서 그런 거 아닐까요 ㅎㅎ |
choyeongju
reviewed
Jan 21, 2025
| import org.android.bbangzip.presentation.util.modifier.applyFilterOnClick | ||
| import org.android.bbangzip.ui.theme.BbangZipTheme | ||
|
|
||
| @Composable |
| @Composable | ||
| fun AddSubjectCard( | ||
| modifier: Modifier = Modifier, | ||
| onClick: () -> Unit = {}, |
| import org.android.bbangzip.presentation.util.base.BaseContract | ||
|
|
||
| class SubjectContract { | ||
| @Parcelize |
Comment on lines
+13
to
+14
| @Inject | ||
| constructor( |
app/src/main/res/values/strings.xml
Outdated
| @@ -68,7 +68,12 @@ | |||
| <!-- component - textfield --> | |||
| <string name="textfield_character_counter">%s/%s</string> | |||
|
|
|||
| <!-- empty view --> | |||
| <string name="empty_view_text">Empty View</string> | |||
|
|
|||
| <!-- login --> | |||
| <string name="login_title">제 과제 빵점 사장님은\n이번 학기 백점!</string> | |||
beom84
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
Uncompleted Tasks 😅
To Reviewers 📢