Add Keychron Q3 HE #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Plugin has been added, as far as the firmware that is up to Keychron to push a fix as we do not modify forks if we can help it past the SRGBP support. You did the right thing by opening an issue and when they address it I will apply the fix to pre-compiled firmware. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for the Keychron Q3 HE. As the Q3 HE is identical in layout to the Q3 ANSI Encoder, the plugin code for the Q3 ANSI Encoder is utilized as a base.
The only things modified are:
ProductID()to return0x0b30for the Q3 HENote
The Q3 HE firmware source code has an incorrect LED configuration, so SignalRGB will apply effects incorrectly.