Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger a recomposition when a route volume changes #31

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Trigger a recomposition when a route volume changes #31

wants to merge 1 commit into from

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Feb 13, 2025 •
edited
Loading

Description

Address the TODO in MediaRouteControllerDialog by triggering a recomposition when a route volume changes.

Changes made

  • Trigger a recomposition when a route volume changes.

@MGaetan89 MGaetan89 requested a review from StaehliJ February 13, 2025 13:17
@MGaetan89 MGaetan89 self-assigned this Feb 13, 2025
@MGaetan89 MGaetan89 linked an issue Feb 13, 2025 that may be closed by this pull request
Improve group volume management #21
Open
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2025 •
edited
Loading

Code Coverage

Overall Project 1.7% -0.1% 🟢
Files changed 0% 🟢

Module Coverage
Kover Gradle Plugin XML report for : 1.7% -0.1% 🟢
Kover Gradle Plugin XML report for :mediarouter-compose 1.7% -0.1% 🟢
Files
Module File Coverage
Kover Gradle Plugin XML report for : MediaRouteControllerDialog.kt 0% -0.24% 🟢
Kover Gradle Plugin XML report for :mediarouter-compose MediaRouteControllerDialog.kt 0% -0.24% 🟢

@MGaetan89 MGaetan89 force-pushed the 21-improve-group-volume-management branch from 9ee7090 to 94ac930 Compare February 13, 2025 13:24
@MGaetan89 MGaetan89 force-pushed the 21-improve-group-volume-management branch from 94ac930 to cfa5c8a Compare February 14, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StaehliJ StaehliJ Awaiting requested review from StaehliJ

At least 1 approving review is required to merge this pull request.

Assignees

@MGaetan89 MGaetan89

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve group volume management
1 participant
@MGaetan89