Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ› [Bug] torch μ„€μΉ˜ 문제 : μŠ€μ™‘νŒŒμΌ μ΄μš©ν•΄ λ©”λͺ¨λ¦¬ 문제 ν•΄κ²° #31

Merged
merged 3 commits into from
Jul 28, 2024
Merged

πŸ› [Bug] torch μ„€μΉ˜ 문제 : μŠ€μ™‘νŒŒμΌ μ΄μš©ν•΄ λ©”λͺ¨λ¦¬ 문제 ν•΄κ²° #31

merged 3 commits into from
Jul 28, 2024

Conversation

88dldl
Copy link
Member

@88dldl 88dldl commented Jul 28, 2024

πŸ“ PR νƒ€μž…

  • κΈ°λŠ₯ μΆ”κ°€
  • 버그 μˆ˜μ •
  • μ˜μ‘΄μ„±, ν™˜κ²½ λ³€μˆ˜, λΉŒλ“œ κ΄€λ ¨ μ½”λ“œ μ—…λ°μ΄νŠΈ
  • 기타 μ‚¬μ†Œν•œ μˆ˜μ •

❗️ κ΄€λ ¨ 이슈 링크

Close #28

πŸ” λ³€κ²½ 및 좔가사항

  • μŠ€μ™‘νŒŒμΌ 생성해 λ©”λͺ¨λ¦¬ 문제 ν•΄κ²°ν–ˆμŠ΅λ‹ˆλ‹€
  • embedding.pyνŒŒμΌμ€ κΈ°μ‘΄ @chanmin-00 이 μž‘μ„±ν•œ μ½”λ“œλ‘œ λŒλ €λ‘μ—ˆμŠ΅λ‹ˆλ‹€ !

πŸ“š 레퍼런슀 (λ˜λŠ” μƒˆλ‘œ μ•Œκ²Œ 된 λ‚΄μš©) ν˜Ήμ€ κΆκΈˆν•œ 사항듀

βœ… 체크 리슀트

  • PR ν…œν”Œλ¦Ώμ— λ§žμΆ”μ–΄ μž‘μ„±ν–ˆμ–΄μš”.
  • λ³€κ²½ λ‚΄μš©μ— λŒ€ν•œ ν…ŒμŠ€νŠΈλ₯Ό μ§„ν–‰ν–ˆμ–΄μš”.
  • ν”„λ‘œκ·Έλž¨μ΄ μ •μƒμ μœΌλ‘œ λ™μž‘ν•΄μš”.
  • PR에 μ μ ˆν•œ 라벨을 μ„ νƒν–ˆμ–΄μš”.
  • λΆˆν•„μš”ν•œ μ½”λ“œλŠ” μ‚­μ œν–ˆμ–΄μš”.

@88dldl 88dldl added the bug Something isn't working label Jul 28, 2024
@88dldl 88dldl self-assigned this Jul 28, 2024
@88dldl 88dldl merged commit b706f70 into develop Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@88dldl 88dldl

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

πŸ› [Bug] torch 배포 μ—λŸ¬ μˆ˜μ •
1 participant
@88dldl