Fix ci/windows #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was removed with C++ 17
Or should this just be replaced with std::system_error? It's hard to tell, whether something further below still is from Boost and hence will throw such an exception
The use of Chocolatey is surprisingly inconsistent
Otherwise, the default and newest version known is the 14.xxx, which is quite old.
SSoelvsten
force-pushed
the
fix-ci/windows
branch
2 times, most recently
from
d5e85ff to
be1add4
Compare
There are many small things here, that unecessarily adds to the mental
complexity of the codebase. Yet, I see no need to keep it as such to save
sligthly on diskspace.
- Made all comments align with column 80 (most were aligned with 65, but not
consistently so)
- Place `{` bracket for all class and function scope-openings on their own line.
Furthemore, if the function is short, add whitespace around `{` and `}` to
make it easier to identify.
- Place inheritance and member initialization list on its own line. This makes
it (1) more clearly separated from the rest and (2) better respects the column
limit of the remaining code.
- Add vertical whitespace between member functions to better convey what goes
together.
- Enforce each line has at most a single statement.
- Make all classes follow the same ordering between *friend*, *variables*,
*operators*, *constructors*, and so on.
- Add empty documentation comment as separator between functions.
- Add missing documentation comments for `tpie::packed_array`
This workaround is not necessary anymore for newer versions of Visual Studio
Microsoft's standard library assumes that a const version of tpie::packed_array::iterator and similar only are immutable with respect to the index, not the value in said index. That is, they assume the iterator reflects a 'T* const' semantics, whereas the prior version implemented a 'const T* const' semantics."
SSoelvsten
force-pushed
the
fix-ci/windows
branch
from
be1add4 to
c028540
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test PR for thomasmoelhave#257