-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azure: support Hub/Spoke network architecture and add Fortinet deployment #763
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many many comments.
I just checked the logic of the new code. I didn't check whether the terraform usage of the new components is correct or not, as it is pretty complex.
In any case, I miss some documentation in the terraform.tfvars.example
file. This is the file most people use rather than the README file
0d3aa97
to
d97ff3e
Compare
3194a74
to
ae1a6b0
Compare
cab6969
to
da84d5c
Compare
…fen/ha-sap-terraform-deployments into mayerhofen
…fen/ha-sap-terraform-deployments into develop-mayerhofen
…terraform-deployments into develop-mayerhofen
…terraform-deployments into mayerhofen
…fen/ha-sap-terraform-deployments into mayerhofen
…terraform-deployments into develop-mayerhofen
Develop mayerhofen
Hub/Spoke Architecture
This adds support for Microsoft Azure's Hub/Spoke Architecture.
It does so by implementing a new variable
network_topology
which is set toplain
(current setup) by default.The new variable executes different terraform modules called
network_{plain,hub,spoke}
which implement the different network scenarios.If
network_topology="hub_spoke"
is set, the new hub/spoke scenario is deployed.A refernce to "Use Hub/Spoke network architecture" is in
README.md
and examples (to just uncomment) are interraform.tfvars
.e.g.
plain network (default/current setup)
The plain network is still the default.
create hub + spoke network
To create both Hub/Spoke networks and a bastion host, set this in
terraform.tfvars
:existing hub + create spoke network
To use an existing Hub network and bastion host and only deploy the Spoke network, set this in
terraform.tfvars
:Fortinet Deployment