Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize codebase structure #62

Open
wants to merge 15 commits into
base: devel
Choose a base branch
from
Open

Reorganize codebase structure #62

wants to merge 15 commits into from

Conversation

vmezzela
Copy link
Collaborator

@vmezzela vmezzela commented Jan 8, 2025

This Pull Request does not change how things work in klp-build, instead it aims at reorganizing the code.

Two new packages have been introduced: klplib and plugins. The majority of modules have been relocated based on the following reasoning:

  • Modules that implement a command (e.g., setup, extract, inline) are placed in the plugins package.
  • Internal modules and shared utilities are grouped under the klplib package.

However, this reorganization is not complete, as it would require to further split the functionalities of each class. At the moment, I believe that the codebase is not yet ready for such a change. I’d like to first refactor the classes to remove inheritance from Config. Once that’s done, I’ll be able to continue with the reorganization more effectively.

@vmezzela vmezzela added the enhancement New feature or request label Jan 8, 2025
@vmezzela vmezzela requested review from marcosps and fgyanz January 8, 2025 13:36
@vmezzela vmezzela mentioned this pull request Jan 8, 2025
@vmezzela
Copy link
Collaborator Author

vmezzela commented Jan 8, 2025

Rebased on top of #63

Signed-off-by: Vincenzo MEZZELA <[email protected]>
Signed-off-by: Vincenzo MEZZELA <[email protected]>
Signed-off-by: Vincenzo MEZZELA <[email protected]>
Signed-off-by: Vincenzo MEZZELA <[email protected]>
Signed-off-by: Vincenzo MEZZELA <[email protected]>
Signed-off-by: Vincenzo MEZZELA <[email protected]>
Signed-off-by: Vincenzo MEZZELA <[email protected]>
Signed-off-by: Vincenzo MEZZELA <[email protected]>
Signed-off-by: Vincenzo MEZZELA <[email protected]>
Signed-off-by: Vincenzo MEZZELA <[email protected]>
Signed-off-by: Vincenzo MEZZELA <[email protected]>
@vmezzela
Copy link
Collaborator Author

Rebased on top of #61

Copy link
Collaborator

@marcosps marcosps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested locally and it worked as expected. Also, the code is much better organized, thanks a lot for doing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants