Staging extension: fix the return value of set_status_report() (fixes #…

…158)
SUSE · May 9, 2024 · 24930b4 · 24930b4
1 parent 684aebf
commit 24930b4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/osctiny/extensions/staging.py b/osctiny/extensions/staging.py
@@ -378,7 +378,7 @@ def set_status_report(self, project: str, repo: str, build_id: str, report: Chec
         )
 
         parsed = self.osc.get_objectified_xml(response)
-        if response.status_code == 200 and parsed.get("code") == "ok":
+        if response.status_code == 200:
             return True
 
         return False
diff --git a/osctiny/tests/test_staging.py b/osctiny/tests/test_staging.py
@@ -1,5 +1,6 @@
 import re
 
+from lxml import etree
 import responses
 
 from osctiny.models.staging import ExcludedRequest, CheckState, CheckReport
@@ -234,7 +235,7 @@ def callback(request):
             self.assertEqual(elem.short_description.text, report.short_description)
             self.assertEqual(elem.url.text, report.url)
 
-            return 200, {}, "<status code=\"ok\"/>"
+            return 200, {}, etree.tostring(report.asxml()).decode()
 
         responses.add_callback(
             method="POST",