-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type annotations and models #155
Conversation
* Added more type annotations * Use `E` factory in models instead of extension code
6e02d75
to
dad2d03
Compare
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
Hey, while we're at it... Would you mind adding a return type annotation of I would have done so myself, but GitHub doesn't let me add comments and suggestions outside of the context of changes and I didn't just want to push my own commit into a branch I'm reviewing... |
I was hoping you would not notice that oversight because |
I have to admit that the use of LGTM! |
E
factory in models instead of extension code