Adding an initial keyfile support embedded in initramfs #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not the one to review this but just to make it faster: you have messed up the indentation. |
|
Thanks for that, didn't noticed, gotta fix |
|
It's still bad. The easiest way to see it might be by navigating to "Files changed" tab which shows changes from all commits nicely. You can also search for tab characters. The file is indented using space so there probably should by no tab characters introduced by this change. |
|
Welp, vim played me. A :retab did it |
Embedding a keyfile in the initramfs encrypted is useless, better use a password directly
|
Added the files adding feature of #30 since we have common goals |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using cryptomount from grub the initramfs will ask a second time the LUKS password as it is not aware it has been mounted before.
This pull request add a simple keyfile support internally.
Documentation is also updated.