-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GEN-1516, GEN-1555, GEN-1576] make table update cohort specific #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge-Bionetworks/genie-bpc-pipeline into GEN-1516-table_update_cohort_specific merge upstream changes
Update README file to reflect new parameters in update_data_table.py
danlu1
commented
Oct 24, 2024
danlu1
commented
Oct 24, 2024
danlu1
commented
Oct 24, 2024
danlu1
commented
Oct 24, 2024
danlu1
commented
Oct 24, 2024
danlu1
commented
Oct 24, 2024
rxu17
reviewed
Oct 24, 2024
rxu17
reviewed
Oct 24, 2024
rxu17
reviewed
Oct 24, 2024
rxu17
reviewed
Oct 24, 2024
…ge-Bionetworks/genie-bpc-pipeline into gen-1516-table_update_cohort_specific merge upstream changes
rxu17
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just minor comments
danlu1
changed the title
[GEN-1516, GEN-1555] make table update cohort specific
[GEN-1516, GEN-1555, GEN-1576] make table update cohort specific
Oct 28, 2024
rxu17
reviewed
Oct 28, 2024
rxu17
reviewed
Oct 28, 2024
thomasyu888
reviewed
Oct 29, 2024
thomasyu888
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 LGTM! Please make sure all of Rixing's comments are addressed!
Co-authored-by: Thomas Yu <[email protected]>
…ge-Bionetworks/genie-bpc-pipeline into gen-1516-table_update_cohort_specific merge upstream changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Solution:
Testing: