fix(agora): migrate InputSwitch to ToggleSwitch (AG-1709), remove styles specific to removed gene-druggability component (AG-1710) #3032
+7
−307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hallieswan
commented
Mar 10, 2025
hallieswan
commented
Mar 10, 2025
…specific to gene-druggability component
hallieswan
force-pushed
the
agora/AG-1709
branch
from
a2438d6 to
b7bdd2b
Compare
|
@hallieswan Why is the box titled "RNA-Differential Expression" shifted vertically when interacting with the toggle that lives inside this box? |
@tschaffter When the switch is toggled, a filter is added so that only differential expression for genes + tissues with significant p-values are displayed. Displaying the filter shifts the control panel downwards (including the RNA - Differential Expression dropdown). significance_toggle.mov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We recently updated to PrimeNG v19 from v17. There were a number of changes to the component names and style classes from v17 to v18+, see here. The
InputSwitchcomponent was renamedToggleSwitch. This PR updates the Agora components accordingly.We also recently removed an unused component (#3026). This PR also removes remaining styles specific to this component.
Related Issues
Changelog
ToggleSwitchinstead ofInputSwitchValidation
Current dev:
currentdev_toggleswitch.mov
New dev:
newdev_toggleswitch.mov
Fix:
fix_toggleswitch.mov