Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team plan view #42

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Team plan view #42

wants to merge 6 commits into from

Conversation

WendiFan
Copy link
Contributor

Pull Request: Introduce Plan View for Teams

Changes Made

[List the key changes made in this PR. Use bullet points for clarity]

Plan view that is atm accessible for teams by appending /plan to the url. Features include:

  • Canvas with calendar view/styling, with ability to infinitely scroll (ish).
  • Questions displayed on canvas in positions corresponding to their resolution date on the calendar
  • Default displays user's (editable) predictions if question is unresolved, and the resolution if it is
  • Option to toggle view to any user on the team, or the community view
  • Ability to reposition the questions on the view, with a tooltip with a hint displaying the resolution date
  • Ability create connections between questions

Default view:
image
Community view:
image
User view:
image
Resolved question:
image
Long question:
image

Changes not covered in PR:

  • Support for MCQ
  • Saving the connections created between questions
  • Saving the positioning of questions set by user

Areas for improvement

  • Calendar styling does not generate infinitely, only for a fixed number of months (set to +/-3 months atm). Solutions could be to: (easy) not allow infinite scroll or (harder) allow infinite scrolling, with on the fly generation of nodes in the view range
  • Pop up modal of question for more details when clicked from canvas
  • Positioning of questions are rendered randomly per re-render, I'd like to have at least a local save for the user's changes so they don't jump around
  • [currently commented out] Support to change the resolution date on the canvas. The commented out code mostly works, but because of the random rerendering of the question nodes and possibly some other issues this is not working as nicely as I'd like yet
  • Condensed UI to show the updateable prediction box and a resolution button in the nodes, so questions can be resolved in the view

Testing

No automated tests added, manual testing in local dev env with a variety of scenarios (different users, length of questions, resolved and unresolved questions, questions with and without predictions, etc). Known limitations include MCQ support. Unknown limitations include stress testing for higher volumes of questions.

@WendiFan WendiFan requested a review from adam-binks August 19, 2024 05:44
Copy link

vercel bot commented Aug 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
forecast-bot ❌ Failed (Inspect) Aug 19, 2024 5:44am

@adam-binks adam-binks marked this pull request as draft September 13, 2024 11:47
@adam-binks adam-binks removed their request for review September 13, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant