Better and faster AES encryption for AA web rediction #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sahayak-bot
added
documentation
Updated quotes
dheerajkhardwal
pushed a commit
that referenced
this pull request
Dec 3, 2021
Update response specification for LSP usecase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current web redirection implementation performs key derivation every time encryption/decryption is performed and is very slow not scalable. This is due to the high iteration count of 65k during key derivation. Key derivation is required for weak human readable passwords. However if strong random password with high entropy is used, then there is no need to perform key derivation every time. The Java sample in this pull request also has a method for generating random 32 byte passwords which can be used for generating and sharing passwords between AA and FIU.
This performance issue was also discussed in stack exchange and can be found below. The sample implementation is based on the suggestions made in this post:
https://security.stackexchange.com/questions/254422/use-pre-computed-pbkdf2-key-with-high-iteration-count-as-password
We may need to allow co-existence of this new method and old one, hence it is better to create a separate branch of the current version or tag it.