Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.7.2 - fixes to restart behavior #18

Merged
merged 5 commits into from
Jan 15, 2025
Merged

1.7.2 - fixes to restart behavior #18

merged 5 commits into from
Jan 15, 2025

Conversation

shawnrushefsky
Copy link
Collaborator

@shawnrushefsky shawnrushefsky commented Jan 15, 2025

  • fixed a bug where comfy exits would not correctly reject a promise, causing the restart behavior to not work
  • fixed a bug where a failing warmup workflow was ignored, which allowed the server to start anyways, and pass health checks. Now if the warmup workflow fails, the server will not become healthy, and will instead exit.
  • fixed a bug in the release workflow
  • fixed a typo in the readme
  • add github action workflow for building docker images when a release is published

@shawnrushefsky shawnrushefsky marked this pull request as draft January 15, 2025 15:42
@SaladTechnologies SaladTechnologies deleted a comment from github-actions bot Jan 15, 2025
Copy link

🚀 Download the latest release candidate 🚀

Copy link

🚀 Download the latest release candidate 🚀

Copy link

🚀 Download the latest release candidate 🚀

@shawnrushefsky shawnrushefsky marked this pull request as ready for review January 15, 2025 16:23
Copy link

@rxsalad rxsalad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go!

Copy link

@rxsalad rxsalad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go!

Copy link

@rxsalad rxsalad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go!

@shawnrushefsky shawnrushefsky merged commit 3ab5ca0 into main Jan 15, 2025
1 check passed
@shawnrushefsky shawnrushefsky deleted the 1.7.2 branch January 15, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants