feat: add Transaction Date (#17)

* transaction_date * add to readme * get this version of tap to work on node 20 * include TRANSACTION_DATE defaults in tests --------- Co-authored-by: nexdrew <[email protected]>
SalesVista · Jan 19, 2024 · 0c2d127 · 0c2d127
1 parent 62618f9
commit 0c2d127
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 1 deletion.
diff --git a/README.md b/README.md
@@ -188,6 +188,7 @@ Shortcut to get the plural value defined for `key`. If a singular value is defin
 - `Strings.RULE`
 - `Strings.SALE`
 - `Strings.TEAM`
+- `Strings.TRANSACTION_DATE`
 - `Strings.UNIT`
 - `Strings.VOLUME`
 

diff --git a/package.json b/package.json
@@ -9,7 +9,7 @@
   "scripts": {
     "prepare": "babel src -d lib",
     "pretest": "standard && npm run prepare",
-    "test": "tap --cov test.js",
+    "test": "tap --reporter=classic --cov test.js",
     "coverage": "nyc report --reporter=text-lcov | coveralls",
     "html": "nyc report --reporter=html && open coverage/index.html",
     "release": "standard-version"

diff --git a/src/index.js b/src/index.js
@@ -306,6 +306,7 @@ Strings.PLAN = 'plan'
 Strings.QUOTA = 'quota'
 Strings.RULE = 'rule'
 Strings.SALE = 'sale'
+Strings.TRANSACTION_DATE = 'transaction_date'
 Strings.COMPENSATION = 'compensation'
 Strings.REPORT = 'report'
 Strings.DRAFT = 'draft'
@@ -345,6 +346,7 @@ Strings.DEFAULTS = {
   [Strings.QUOTA]: 'Quota',
   [Strings.RULE]: 'Rule',
   [Strings.SALE]: 'Sale',
+  [Strings.TRANSACTION_DATE]: 'Transaction Date',
   [Strings.COMPENSATION]: {
     singular: 'Compensation',
     plural: 'Compensation'

diff --git a/test.js b/test.js
@@ -824,6 +824,7 @@ tap.test('instance get', t => {
   t.strictEqual(s.get(Strings.GROSS_MARGIN, { abbrev: true }), 'Pft')
   t.strictEqual(d.get(Strings.ANNUAL_CONTRACT_VALUE, { abbrev: true }), 'ACV')
   t.strictEqual(s.get(Strings.ANNUAL_CONTRACT_VALUE, { abbrev: true }), 'ACV')
+  t.strictEqual(d.get(Strings.TRANSACTION_DATE, { abbrev: true }), 'TD')
 
   // 2rd arg object as opts with plural boolean and flu boolean
   t.strictEqual(d.get(Strings.REPORT, { plural: false, flu: true }), 'Report')
@@ -964,6 +965,8 @@ tap.test('defaults', t => {
   t.strictEqual(d.getPlural(Strings.RULE), 'Rules')
   t.strictEqual(d.getSingular(Strings.SALE), 'Sale')
   t.strictEqual(d.getPlural(Strings.SALE), 'Sales')
+  t.strictEqual(d.getSingular(Strings.TRANSACTION_DATE), 'Transaction Date')
+  t.strictEqual(d.getPlural(Strings.TRANSACTION_DATE), 'Transaction Dates')
   t.strictEqual(d.getSingular(Strings.COMPENSATION), 'Compensation')
   t.strictEqual(d.getPlural(Strings.COMPENSATION), 'Compensation')
   t.strictEqual(d.getSingular(Strings.REPORT), 'Report')